Inconsistent formatting when log records contain data about scribe

[eikek]

I can confirm it fixes my issue, thanks!

[darkfrog26]

Can you show some code that reproduces the problem?

[eikek]

Sure, sorry. I might very well have misconfigured something. I'll try to create a minimum example.

[hindog]

I just hit this issue while integrating Scribe into another framework (ZIO). In my case, I adapt each ZIO log to a Scribe LogRecord and pass ZIO's fiber-local LogContext map as the data parameter, but the values aren't coming through. Here's an example to demonstrate the issue:

import scribe._
import scribe.data.MDC

object LogExample extends App{

  MDC.update("key1", "value1")

  log(LogRecord(
    Level.Info,
    Level.Info.value,
    new LazyMessage(() => "Some message"),
    implicitly[Loggable[String]],
    None,
    "file.scala",
    "Class",
    None,
    None,
    None,
    data = Map(
      "key2" -> (() => "value2")
    )
  ))
}

# prints:
2022.05.19 18:04:39:660 [main      ] [INFO ] Class - Some message (key1: value1)

# expected:
2022.05.19 18:04:39:660 [main      ] [INFO ] Class - Some message (key1: value1, key2: value2)

I think @eikek has the right idea, the code seems like it should be something like this:

 val map = MDC.map ++ record.data 
 if (map.nonEmpty) { 
   new TextOutput(map.map {   // map includes both sources vs just the MDC map

[eikek]

Sorry I forgot to respond - thank you for the example @hindog 🙏🏼

[darkfrog26]

Thanks for the code example. I'll take a look at this and get back to you ASAP.

[darkfrog26]

Okay, this is fixed and I'm doing a release now for 3.8.3 that will include it.