Mutation exceptions always return 200 about graphqlbundle

[mcg-web]

Hi,

We don't use http status code because in graphQL response can be partially successful. What is the code for this case?... The approach is much different than rest api because you can request many resources in an unique query... It is not recommend but if you want to use it in your app you can create a custom controller here the way was doing this at the beginning of this bundle.

[ooflorent]

Previously we were returning HTTP error codes but we found it counter-productive. GraphQL is not REST. In REST, error codes are part of the response. They have a useful meaning. In GraphQL the response is the JSON payload, not the HTTP error code.

The JS implementation has 4 possible error codes:

• 200: everything is fine
• 400: the GraphQL request has failed
• 405: the HTTP request is neither GET nor POST
• 500: unhandled server error

Maybe we could use 400 error code again. We rolled-back this change because it was causing troubles with react-relay.

[mcg-web]

So here comes a new challenger ! We can implement this 4 error codes in the bundle, or just give the ability of configuring them in each case 🤔.

[benatespina]

It would be nice if we had a status code inside the error. Before "message" key for example.

[mcg-web]

we can't touch the errors format but adding http status codes like the express integration is possible. I'll try to work on a POC this week-end...

[renatomefi]

@mcg-web do you have some material/links to support this? Maybe someone else can pick this up!

[mcg-web]

just re-implementing this can be sufficient right now (with some tests to cover it)... maybe the JS implementation can help on this...

[mcg-web]

This will not be implement server side cause this conflicting with major clients like Apollo http error. Anyway you can use error formatting to add information to errors...