n+1 problem about laravel-follow

[overtrue]

OK, I am working on this.

[Livijn]

Something like this should work (haven't tried):

public function hasFavorited($target, $class = __CLASS__)
 {
    return $this->relationLoaded('favorites') 
        ? $this->favorites->where('pivot.followable_id', $target->id)
            ->where('followable_model', get_class($target))
            ->count()
        : Follow::isRelationExists($this, 'favorites', $target, $class);
}

[xsaad67]

Is there any update on eager loading?

[overtrue]

@Livijn @xsaad67 Fixed.

[xsaad67]

Hy thanks for the response but how do I call the upvoters relationship on eager loading? Like Post::with("upvoters")->get(); ?

[overtrue]

yes

[rdgout]

Hi @overtrue

When I use the loaded relation the morph gets a User model. However the relationKey checks for user_id whilst the User model usually contains a id field.
That way, the entire new if check never gets any results.

Can you fix this?

Reproducing is easy:

1. Create 2 user models
2. Follow user 1 from user 2
3. Follow user 2 from user 1
4. Fetch user 2 whilst eager loading the followings and followers
5. Check the result for isFollowedBy and isFollowing

Both should be false since the if checks already results in an empty collection.
if the relationKey is 'id' it does work.

        if ($model->relationLoaded($relation)) {
            $relationKey = 'id';

            return $model->{$relation}->where($relationKey, head($target->ids))->isNotEmpty();
        }

[overtrue]

@rdgout I will check this.

[rdgout]

@overtrue

Issue 76 has the same issue I found.

[overtrue]

@rdgout I've fixed the problem. plz take a try with new version.