Comments (5)
It's a very nice (and reasonable) enhancement, it has every reason to be here. I might do it when I have some spare time, but being such an easy issue maybe somebody else who'd like to contribute offers to.
In any case issues like this should stay open to get +1s from other people requesting the same thing, this way we know the most wanted features/bug fixes.
from dragdealer.
Good, I'll try to do it and send a pull request.
from dragdealer.
@skidding I've updated my changes. Please check it once more.
from dragdealer.
Just merged your improvement. Thanks a lot @w0rm, this is the reason I struggled to put Dragdealer out there once again. My fear is that even though the project is friendlier and more accessible from an open source perspective, the code might not be written so easy to read and follow, since it was written a while ago. But you proved me wrong :)
PS. Travis CI in combination with Sauce Labs something fails at running tests properly on a pull request, but I ran then locally to make sure. They run just fine on the master branch after: https://travis-ci.org/skidding/dragdealer/builds/17190829
PPS. You can check out http://hub.github.com/ to open pull requests. I use it all the time to turn an issue into a pull-request. Not always useful when you might end up having more than one pull-request per issue though
from dragdealer.
@skidding I only ran tests locally using grunt connect:server:keepalive
, didn't know how to make it work with Sauce Labs. Let me know if something should be done on my side for it to work.
I made a mistake not referencing this issue in pull request body when I created it, so it wasn't converted. I then edited pull request body and added link to the issue. Thanks for the tip though, I will check hub.
from dragdealer.
Related Issues (20)
- dragStopCallback is called when clicking handle element
- set a minimum range?
- Infinite number of tiles HOT 7
- Set step to start on when initialising HOT 1
- autoplay HOT 1
- Mousewheel Functionality
- Dragdealer does not take into account scale() css3 transform when calculating handle positions
- How to disable point to scroll outside the handle? HOT 4
- Change color of the 'handle red-bar' depending on the value? HOT 1
- Handle bar still moving even when dealer is disabled. HOT 1
- preventDefault when clicking an element inside Dragdealer HOT 1
- Can you change drag speed? HOT 2
- dragdealer infinity slides HOT 5
- dragdealer number of images HOT 1
- Type script Definitions HOT 1
- Unable to preventDefault inside passive event listener invocation.
- Is Dragdealer have destroy method or analog to stop calling requestAnimationFrame? HOT 3
- how to disable wrapper handle HOT 1
- css: transform scale - DragDealer jumps on entry
- Content scroller but with Horizontal movement? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dragdealer.