GithubHelp home page GithubHelp logo

Comments (7)

ThunderSon avatar ThunderSon commented on August 17, 2024 1

@kingthorin Moving forward, let's set it to Squash and Merge, and when need be, the reviewer can manually take in all commits. Sounds good?

from wstg.

kingthorin avatar kingthorin commented on August 17, 2024 1

Seems fine to me, but it’s not something I can set.

As things are people can use the drop down on the merge button. (It seems to stick with whichever method was most recently used, until changed again.)

from wstg.

caperutxa avatar caperutxa commented on August 17, 2024

I do not like squash strategy for merges.

Squash remove the commit history in benefit to merge in order to obtain a single view to a group of commits but there are ways to see all changes in a group of commits, between tags... and the history commits is not lost

from wstg.

kingthorin avatar kingthorin commented on August 17, 2024

IMHO the user's feature branch (for lack of a better term) commit history is irrelevant to the overall project. But that's just my 2 cents.

from wstg.

kingthorin avatar kingthorin commented on August 17, 2024

Refs:

from wstg.

ThunderSon avatar ThunderSon commented on August 17, 2024

I'd mainly recommend the usage of squash strategy when a lot of bad commits have been committed to a PR. Otherwise, the commits are needed to re-track the changes if need be, instead of having it all in one commit.

from wstg.

patrickceg avatar patrickceg commented on August 17, 2024

Should we close this issue? We've been through a whole month of awesome contributions and I don't think this was ever a problem.

from wstg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.