Comments (7)
@kingthorin Moving forward, let's set it to Squash and Merge, and when need be, the reviewer can manually take in all commits. Sounds good?
from wstg.
Seems fine to me, but itβs not something I can set.
As things are people can use the drop down on the merge button. (It seems to stick with whichever method was most recently used, until changed again.)
from wstg.
I do not like squash strategy for merges.
Squash remove the commit history in benefit to merge in order to obtain a single view to a group of commits but there are ways to see all changes in a group of commits, between tags... and the history commits is not lost
from wstg.
IMHO the user's feature branch (for lack of a better term) commit history is irrelevant to the overall project. But that's just my 2 cents.
from wstg.
Refs:
- https://help.github.com/en/articles/about-merge-methods-on-github
- https://help.github.com/en/articles/configuring-pull-request-merges
from wstg.
I'd mainly recommend the usage of squash strategy when a lot of bad commits have been committed to a PR. Otherwise, the commits are needed to re-track the changes if need be, instead of having it all in one commit.
from wstg.
Should we close this issue? We've been through a whole month of awesome contributions and I don't think this was ever a problem.
from wstg.
Related Issues (20)
- Possible error in 4.9.2 Testing for Padding Oracle
- Ambiguity in the summary related to the test case Testing for Bypassing Authorization Schema HOT 4
- [fix] : Typo in CONTRIBUTING.md
- [Fix] : Fix Formatting Issue in OWASP Web Security Testing Guide Document
- [fix]: Fix Formatting Issue in OWASP Web Security Testing Guide Document
- E-Book action artifact expired HOT 3
- yjh HOT 1
- fghhyg
- vbbbbbbbbbbbbbm
- jjjjjjjjjjjjjjj
- Adding "How to Test" for the WSTG Checklist [Work in Progress] HOT 17
- Adding "Test for Simultaneous sessions" in Session Management Testing HOT 2
- Provide a simplified Chinese translation version for this project HOT 1
- Cookies-Link under 4.08 #cookies points to itself HOT 1
- Invisible code parts - bright blue text on the blue background HOT 6
- Check List Translation to french and arabic HOT 3
- Update Privilege Escalation's Weak SessionID Section
- Juice Shop - Error Handling link not found HOT 1
- Grammar error HOT 1
- Review and update subdomain takeover content
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wstg.