GithubHelp home page GithubHelp logo

Comments (3)

parallels999 avatar parallels999 commented on May 26, 2024 1

That would fill the DB with unnecessary data. 👎

from laravel-auditing.

parallels999 avatar parallels999 commented on May 26, 2024 1

protected function getUpdatedEventAttributes(): array
{
$old = [];
$new = [];
foreach ($this->getDirty() as $attribute => $value) {
if ($this->isAttributeAuditable($attribute)) {
$old[$attribute] = Arr::get($this->original, $attribute);
$new[$attribute] = Arr::get($this->attributes, $attribute);
}
}
return [
$old,
$new,
];
}

You could override getUpdatedEventAttributes, It should go through all the attributes, instead of just the dirty ones

foreach ($this->attributes as $attribute => $value) {
    if ($this->isAttributeAuditable($attribute)) {
        $old[$attribute] = Arr::get($this->original, $attribute);
        $new[$attribute] = $value;
    }
}

from laravel-auditing.

nicktan147 avatar nicktan147 commented on May 26, 2024

That would fill the DB with unnecessary data. 👎

I'm well aware of this, the reason is we need it to do a checksum against the old and the new values.

from laravel-auditing.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.