GithubHelp home page GithubHelp logo

Comments (10)

willpower232 avatar willpower232 commented on June 28, 2024 2

Interesting, I'll leave it for @erikn69 to investigate the specifics.

The SQL needs a double slash so

SELECT count(id) FROM `audits` WHERE `auditable_id` = 4 AND `auditable_type` = 'App\\Models\\TheModel'

from laravel-auditing.

willpower232 avatar willpower232 commented on June 28, 2024 1

Are you able to include the rest of the stack trace for some more context? At least the lines before it reaches your app.

from laravel-auditing.

erikn69 avatar erikn69 commented on June 28, 2024 1

13.6.4

In my opinion this was already solved in later versions, I removed the whereIn: #933/files
Try v13.6.7


I'll leave it for @erikn69 to investigate the specifics.

Sorry, I can't do it at all
and most of them aren't real bugs, it's a waste of time chasing ghosts

Also, take some time to review the code, I have noticed that you have not caught up yet
Open a discussion if you don't understant something, and I will try to explain it to you, I have only contributed out of necessity, but the code is really small, and it is not complex

from laravel-auditing.

rebbieboi avatar rebbieboi commented on June 28, 2024

Are you able to include the rest of the stack trace for some more context? At least the lines before it reaches your app.

updated the post with the data requested

from laravel-auditing.

willpower232 avatar willpower232 commented on June 28, 2024

Thanks, are you able to confirm how many audit entries for this model you have?

from laravel-auditing.

rebbieboi avatar rebbieboi commented on June 28, 2024

Thanks, are you able to confirm how many audit entries for this model you have?

afraid I don't know how to query the 'auditable_type' column since doing like below doesn't result with anything

SELECT count(id) FROM `audits` WHERE `auditable_id` = 4 and `auditable_type` =\ 'App\Models\TheModel';

and this fails:

SELECT count(id) FROM `audits` WHERE `auditable_id` = 4 and `auditable_type` = App\Models\TheModel;

from laravel-auditing.

rebbieboi avatar rebbieboi commented on June 28, 2024

Thanks, are you able to confirm how many audit entries for this model you have?

EDIT: it was 74k records, I manually pruned it instead as I remember you can just use LIKE to filter using auditable_type. However, I still hope that the package can handle more records when it's deleting them automatically.

from laravel-auditing.

rebbieboi avatar rebbieboi commented on June 28, 2024

Interesting, I'll leave it for @erikn69 to investigate the specifics.

The SQL needs a double slash so

SELECT count(id) FROM `audits` WHERE `auditable_id` = 4 AND `auditable_type` = 'App\\Models\\TheModel'

thank you for that! also, I set it as 'threshold' => 2500, in the config

from laravel-auditing.

rebbieboi avatar rebbieboi commented on June 28, 2024

13.6.4

In my opinion this was already solved in later versions, I removed the whereIn: #933/files Try v13.6.7

I'll leave it for @erikn69 to investigate the specifics.

Sorry, I can't do it at all and most of them aren't real bugs, it's a waste of time chasing ghosts

Also, take some time to review the code, I have noticed that you have not caught up yet Open a discussion if you don't understant something, and I will try to explain it to you, I have only contributed out of necessity, but the code is really small, and it is not complex

aye, looks like that version does fix that problem. thanks!

from laravel-auditing.

willpower232 avatar willpower232 commented on June 28, 2024

@erikn69 thanks for confirming, I only tagged you because I knew you had been in that part of the code very recently and would know what the issue was straight away 🙏

from laravel-auditing.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.