Progress bar for uploading assets about gh

[calavera]

yeah, I saw it before. A solution that comes to my mind is to combine all the uploads in one bar and update it according to the bytes sent.

[calavera]

I've been playing with pb tonight and I got some interesting results. Unfortunately, I had to change octokit, and since it was just an experiment I haven't committed anything yet.

This is the progress indicator uploading a release, it shows the bytes uploaded and the total to update, I kinda miss the number of files to upload and uploaded:

[owenthereal]

@calavera Yeah, I assume we need to change octokit's UploadService.UploadAsset to pass an io.ReadCloser instead of os.File, since Request.Body takes it. But this change is actually a good one IMO and it makes the method more generic by taking any io.ReadCloser.

I agree it'd be more informative to see the progress of each file. Would displaying a progress bar for each file make sense? I mean it shows the file and the number of the bytes. If not, I think showing number of files would be sufficient for now.

[owenthereal]

I think I may not explain clearly, to use pb, I was thinking to use it as a io.Reader (it implements this interface), which we may end up concatenating the input file with the pb reader by using io.MultiReader.

[calavera]

I don't really think we can print a bar per file. If you print any new line character (\n) you stop having that "progress bar" effect to have a bunch of lines that don't make sense. The trick to print the bar is to start the buffer always in the same position.

Yep, it was clear, that's what I did, I modified octokit to accept an io.ReadCloser instead of an os.File.

[owenthereal]

I don't really think we can print a bar per file. If you print any new line character (\n) you stop having that "progress bar" effect to have a bunch of lines that don't make sense. The trick to print the bar is to start the buffer always in the same position.

Ah...right...

I agree with you that it's more informative to see the numbers of each file than the progress of the overall bytes. I'm closing this issue for now and let's revisit it later if necessary. Thanks for trying pb out! I played with it a bit too and it seems like a neat lib :).