GithubHelp home page GithubHelp logo

Why can't we add a check in `stakeNFT` before staking is executed, such that it reverts if a token is already deposited by a user? about artstakes HOT 1 OPEN

probablyangg avatar probablyangg commented on August 18, 2024
Why can't we add a check in `stakeNFT` before staking is executed, such that it reverts if a token is already deposited by a user?

from artstakes.

Comments (1)

owl11 avatar owl11 commented on August 18, 2024

Thank you for checking out the code, it is checked, just within the internal function _stakeNFT()

require(!stakedTokens[_NFTAddr][_tokenId], "Token already staked");

since the function checks the msg.sender metadata in the internal function, it is not checked in the public one, it can be moved onto the public one, however only the internal one fetches the user's registered metadata

function _stakeNFT() internal {
require(
registeredMetadata[msg.sender] == true,
"Unregistered Metadata"
);
(uint256 _tokenId, , , , , , , ERC721 _NFTAddr) = getUserMetadata(
msg.sender
);

it however fails to account for multiple NFT's from the same user

from artstakes.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.