Comments (2)
michaelstingl
commented on August 29, 2024
Regular workflow in the PR:
- Open PR
- Code review
- QA
- Merge
Additional there's another round of QA before the release.
In the case of #224 I get your point. If it builds and @davigonz and/or @hosy approve the code, I have no problem to merge. (just did)
In #228 there was a request for testing (#228 (comment)), so I need to check with the team.
from android-library.
davigonz
commented on August 29, 2024
Do we really need a manual test for every PR, or what prevents a merge of
It's not a normal test but an additional check that is worthy in my opinion and has prevented some errors, I remember #180 (comment), if I had not cloned your code and tried to compile it, we would not have noticed that problem, even with the green checks in Travis. Sometimes, just a code review is not enough.
from android-library.
Related Issues (20)
- purpose of OC_X_REQUEST_ID ? HOT 3
- Retrofit ? HOT 1
- Readme and third party HOT 2
- Q: How to build library in JAR format (for legacy eclipse project)? HOT 3
- Clean up no longer used libraries
- Proguard HOT 1
- git tag name suggestion HOT 3
- Use TLS v1, v2
- Exception when exhausting http responses HOT 1
- Inability to work with cloud using OwnCloudBasicCredentials only (not android.accounts.Account) HOT 8
- Create new app in Bitrise to build the library when pushing commits or creating PRs HOT 1
- Use the latest changes of dav4jvm (old dav4Android)
- [New arch] Use Moshi to parse capabilities
- Use Moshi to parse shares HOT 1
- remove okHttpClient singleton
- Remove redundant use of `HttpClient` HOT 1
- Handle wrong transfaired bytes properly
- remove sample app from library
- Handle propfind replies with status 425 as valid HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from android-library.