GithubHelp home page GithubHelp logo

Comments (5)

LukasReschke avatar LukasReschke commented on August 28, 2024

This may be related to oc-1949:

You have to hit enter after you type in a password and then it should say 'Password protected' inside the textbox. I'm not sure if this is the best user experience.

Can you confirm this?

from core.

fmms avatar fmms commented on August 28, 2024

Thanks alot @LukasReschke this was indeed the issue.

I think this is totally none discoverable.

Submitting the password after every key stroke seems like a security issue, as an attacker could see how long it is by counting requests.
I would suggest submit it on leaving the field or closing the menu.

Thanks for you quick help, would have never discovered that.

from core.

LukasReschke avatar LukasReschke commented on August 28, 2024

I would suggest submit it on leaving the field or closing the menu.

This sounds resonable.

@MTGap what do you think?

from core.

jancborchardt avatar jancborchardt commented on August 28, 2024

Yes, submit on blur is good, and there needs to be some feedback like on the email field in the personal settings. (Or better yet, like the account settings fields here on Github with just a checkmark.)

from core.

schiessle avatar schiessle commented on August 28, 2024

I changed it to set the new password as soon as the password filed loses focus.

from core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.