Comments (15)
linusg
commented on June 1, 2024
Still working fine for me. Double check your active layer settings, check what requests are being made, try if the output of verbose mode gives you some clues. Or at least mention what version you were running before that.
Closing for now, feel free to reopen if you can provide more information.
from frontend.
benjaminchodroff
commented on June 1, 2024
Thanks for your help!
owntracks/frontend (2.3.1) in docker latest
owntracks/recorder (0.8.6) in docker latest
Apologies, how do I enable verbose mode when using docker?
I enabled all options (heatmap,last,line,points) in layer settings and I can see the following in the logs. I can't seem to spot any issues. When I click Download, I can easily see all the data points listed.
from frontend.
benjaminchodroff
commented on June 1, 2024
I have reverted the container first to 2.3.0 (broken) and then to 2.2.0 (fixed) with the same data from the recorder. I was able to confirm the issue only gets fixed when I go back to owntracks-frontend v2.2.0. This is definitely a bug, but I'm not well versed enough in javascript to explain why it is happening - there are no errors in the log or in the browser console.
from frontend.
bradeales
commented on June 1, 2024
I'm hitting this issue as well.
from frontend.
benjaminchodroff
commented on June 1, 2024
@linusg I am unable to re-open this issue. Thanksfully, @bradeales has confirmed I'm not the only person seeing this issue. I do think this requires more investigation and I'm willing to help provide any further data to assist. I could also make my server temporarily public if you are willing to investigate it further (really wish I could password protect the site and backend natively!)
from frontend.
ckrey
commented on June 1, 2024
@linusg there seems to be typo here:
git diff
diff --git a/src/store/actions.js b/src/store/actions.js
index 227bcdf..4e41b1d 100644
--- a/src/store/actions.js
+++ b/src/store/actions.js
@@ -130,7 +130,7 @@ const _getDistanceTravelled = locationHistory => {
let lastLatLng = null;
locationHistory[user][device].forEach(location => {
if (
- config.minAccurac !== null &&
+ config.filters.minAccuraccy !== null &&
location.acc > config.filters.minAccuracy
)
return;
diff --git a/src/store/getters.js b/src/store/getters.js
index d1857ce..5e1cdd8 100644
--- a/src/store/getters.js
+++ b/src/store/getters.js
@@ -19,7 +19,7 @@ const filteredLocationHistory = state => {
locationHistory[user][device] = [];
state.locationHistory[user][device].forEach(location => {
if (
- config.minAccurac !== null &&
+ config.filters.minAccuracy !== null &&
location.acc > config.filters.minAccuracy
)
return;
from frontend.
linusg
commented on June 1, 2024
@linusg there seems to be typo here:
Indeed, thanks. Will fix that. BUT this change wasn't even part of the 2.3.0 or 2.3.1 release v2.2.0...v2.3.1
@benjaminchodroff @bradeales the only way you could be running this code in production already is if you built your own image or are using the latest tag, which is strongly discouraged, not only here but in general.
from frontend.
benjaminchodroff
commented on June 1, 2024
Thanks for the fix. Glad we could help spot it. Loving this project - I
really enjoy the capability for my own personal use.
I’m not building the image myself, and pretty certain the issue was present
in the 2.3.0 and 2.3.1 dockerhub images I pulled. I am open to feedback on
this because I’m still learning, but isn’t “latest” commonly used by many
new people to a project to find/update to the projects stable docker image?
Latest does not actually become the latest image pushed - it’s just the one
that is not tagged - which is both dangerous (accidents happen too easily!)
and simultaneously useful. Right or wrong, the “latest” antipattern seems
to have gone mainstream thanks to watchtower and other similar projects.
I’d suggest ensuring all development builds get tagged in the pipeline to
avoid an untested release being set as latest prematurely. Please correct
me if I am mistaken!
…On Sat, May 16, 2020 at 20:45 Linus Groh ***@***.***> wrote:
@linusg <https://github.com/linusg> there seems to be typo here:
Indeed, thanks. Will fix that. BUT this change wasn't even part of the
2.3.0 or 2.3.1 release v2.2.0...v2.3.1
<v2.2.0...v2.3.1>
@benjaminchodroff <https://github.com/benjaminchodroff> @bradeales
<https://github.com/bradeales> the only way you could be running this
code in production already is if you built your own image or are using the
latest tag, *which is strongly discouraged*, not only here but in general.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#36 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBU6RTBMGYGZKNUWZ2J5LLRR2DE3ANCNFSM4NAH75OA>
.
from frontend.
linusg
commented on June 1, 2024
I’m still learning, but isn’t “latest” commonly used by many
new people to a project to find/update to the projects stable docker image?
Latest does not actually become the latest image pushed - it’s just the one
that is not tagged - which is both dangerous (accidents happen too easily!)
and simultaneously useful.
Indeed - it's ambiguous and that should make it a no-go for anyone looking to do more than just some quick testing. It differs for each project of course but you can end up having just the "latest" stable release or the "latest" commit available from master (like here). (https://vsupalov.com/docker-latest-tag/, https://blog.container-solutions.com/docker-latest-confusion)
I’d suggest ensuring all development builds get tagged in the pipeline to
avoid an untested release being set as latest prematurely
Yes, that'd be ideal - but I don't actually have access to this project's Docker Hub account, so it's not something I could configure
from frontend.
bradeales
commented on June 1, 2024
Thanks @linusg for responding on a closed ticket! I was also pulling dockerhub "latest", thinking it was master/stable based on convention. Issue is also present on 2.3.0, and 2.3.1 dockerhub images as far as I can tell.
FYI, I also see it has trouble plotting ancient owntracks data, even though it's visible in the recorder app.
from frontend.
linusg
commented on June 1, 2024
Issue is also present on 2.3.0, and 2.3.1 dockerhub images as far as I can tell.
I'm still not believing that until someone can prove it to me. Again, the actual code changes in 2.3.0/1 are trivial and only add custom options for fetch(), and the dependency upgrades should not affect the map either - in fact, here's a screenshot of me running 2.3.1 via Docker:
All layers working as intended.
FYI, I also see it has trouble plotting ancient owntracks data, even though it's visible in the recorder app.
I don't know what you mean by that - if you feel like that's a bug, please open a separate issue providing the necessary details.
from frontend.
benjaminchodroff
commented on June 1, 2024
https://location.benchodroff.com:8443/
Please feel free to test with my instance
…On Mon, May 18, 2020 at 3:52 PM Linus Groh ***@***.***> wrote:
Issue is also present on 2.3.0, and 2.3.1 dockerhub images as far as I can
tell.
I'm still not believing that until someone can prove it to me. Again, the
actual code changes in 2.3.0/1 are trivial and only add custom options for
fetch(), and the dependency upgrades should not affect the map either -
in fact, here's a screenshot of me running 2.3.1 via Docker:
[image: image]
<https://user-images.githubusercontent.com/19366641/82187776-d44cf480-98e4-11ea-80ee-5bf4ccba8d9e.png>
All layers working as intended.
FYI, I also see it has trouble plotting ancient owntracks data, even
though it's visible in the recorder app.
I don't know what you mean by that - if you feel like that's a bug, please
open a separate issue providing the necessary details.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#36 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBU6RQ3NGN5YH3NZHUHRWTRSDSMVANCNFSM4NAH75OA>
.
from frontend.
benjaminchodroff
commented on June 1, 2024
To compare, you can see 2.2.0 with the same data here:
https://location220.benchodroff.com:8443/
On Mon, May 18, 2020 at 8:25 PM Benjamin Chodroff <
[email protected]> wrote:
… https://location.benchodroff.com:8443/
Please feel free to test with my instance
On Mon, May 18, 2020 at 3:52 PM Linus Groh ***@***.***>
wrote:
> Issue is also present on 2.3.0, and 2.3.1 dockerhub images as far as I
> can tell.
>
> I'm still not believing that until someone can prove it to me. Again, the
> actual code changes in 2.3.0/1 are trivial and only add custom options for
> fetch(), and the dependency upgrades should not affect the map either -
> in fact, here's a screenshot of me running 2.3.1 via Docker:
>
> [image: image]
> <https://user-images.githubusercontent.com/19366641/82187776-d44cf480-98e4-11ea-80ee-5bf4ccba8d9e.png>
>
> All layers working as intended.
>
> FYI, I also see it has trouble plotting ancient owntracks data, even
> though it's visible in the recorder app.
>
> I don't know what you mean by that - if you feel like that's a bug,
> please open a separate issue providing the necessary details.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#36 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABBU6RQ3NGN5YH3NZHUHRWTRSDSMVANCNFSM4NAH75OA>
> .
>
from frontend.
linusg
commented on June 1, 2024
thank you very much. I can indeed see the same bug in your deployed version by inspecting the source maps:
I then took the owntracks/frontend:v2.3.1 image and inspected it:
docker save owntracks/frontend:v2.3.1 | gzip > frontend.tar.gz
mkdir frontend
tar -xvzf frontend.tar.gz -C frontend
cd frontend/5d7b502b9889781f20060ad7051995f25c8d6be1c11aceb61d09205d334b0781/
tar -xvf layer.tar
cd usr/share/nginx/html/js
At that point we can again inspect the source maps:
grep Acc app.73109ba2.js.map
No result - the code you're running is not in that image.
So even though it says "2.3.1" on your version, I suspect that it isn't actually the image tagged with v2.3.1 but latest - it will contain the last released version number until the next release is published. Hope that clears things up.
from frontend.
benjaminchodroff
commented on June 1, 2024
Thanks for helping get to the bottom of this! Yes, it seems the issue is
related to the latest tag image only and hopefully the next release clears
the bug up.
…On Tue, May 19, 2020 at 1:02 AM Linus Groh ***@***.***> wrote:
Hi @benjaminchodroff <https://github.com/benjaminchodroff>,
thank you very much. I can indeed see the same bug in your deployed
version by inspecting the source maps:
[image: image]
<https://user-images.githubusercontent.com/19366641/82238936-f15ae500-992f-11ea-98b1-1c201da057be.png>
I then took the owntracks/frontend:v2.3.1 image and inspected it:
docker save owntracks/frontend:v2.3.1 | gzip > frontend.tar.gz
mkdir frontend
tar -xvzf frontend.tar.gz -C frontend
cd frontend/5d7b502b9889781f20060ad7051995f25c8d6be1c11aceb61d09205d334b0781/
tar -xvf layer.tar
cd usr/share/nginx/html/js
At that point we can again inspect the source maps:
grep Acc app.73109ba2.js.map
No result - the code you're running is not in that image.
So even though it says "2.3.1" on your version, I suspect that it isn't
actually the image tagged with v2.3.1 but latest - it will contain the
last released version number until the next release is published. Hope that
clears things up.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#36 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBU6RTN4NVHVFNWBFWX5P3RSFSY7ANCNFSM4NAH75OA>
.
from frontend.
Related Issues (20)
- Timeline feature HOT 8
- [Feature] elevation change calculation HOT 6
- The frontend is only showing up once, then switching back to standard view on reload HOT 4
- Change default time span thats loaded HOT 3
- Date/time filtering is not working HOT 2
- OSM Map not loading with reverse proxy HOT 4
- Document changing of application path HOT 1
- No line segment drawn on position update HOT 2
- config.js fails with 500 when running owntracks/frontend:latest HOT 5
- GeoJson Download HOT 3
- Wrong order when connecting points with line (frontend does not respect timestamps correctly) HOT 3
- Container just constantly restarts HOT 4
- Can't find servers name HOT 1
- Noob Guide HOT 4
- Websockets and openstreetmaps HOT 1
- Mapbox changed its api
- Dynamic filter minAccuracy
- Frontend stopped connecting to recorder. HOT 10
- Doesn't load map element HOT 5
- Include precompiled dist/ in releases HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from frontend.