Comments (2)
I'm not sure if suppressing the autogeneration of a field if another field uses it as source
would be a sensible default. I can imagine usecases where source
is used to add another representation, instead of replacing the default one all together, and it's also a breaking change. I'll have to check, but I also think that it'd be different behaviour from what DRF's built-in ModelSerializer
does.
from djangorestframework-dataclasses.
DRF built-in serializers are a bit different since they allow partial models by default. But when I set __all__
as fields I indeed get the same behaviour.
from django.db import models
from rest_framework import serializers
class MyModel(models.Model):
id = models.AutoField(primary_key=True)
class MyModel2(models.Model):
id = models.AutoField(primary_key=True)
model = models.ForeignKey(MyModel, on_delete=models.CASCADE)
class MyModelSerializer(serializers.ModelSerializer):
model_id = serializers.PrimaryKeyRelatedField(
queryset=MyModel.objects.all(), source="model"
)
class Meta:
model = MyModel2
fields = "__all__"
MyModel(id=1).save()
MyModelSerializer(data={"model_id": 1}).is_valid(raise_exception=True)
# raises rest_framework.exceptions.ValidationError: {'model': [ErrorDetail(string='This field is required.', code='required')]}
I think probably it is more common that you have one representation of a field by 'source' and don't want to autogenerate another one, but seems hard to change now.
from djangorestframework-dataclasses.
Related Issues (20)
- TYPE_CHECKING imports result in error on type evaluation HOT 8
- Nesting dataclass serializer inside regular serializer can result in <class 'rest_framework.fields.empty'> for optional fields HOT 3
- "Invalid data. Expected a dictionary, but got <dataclass.type>" HOT 2
- bool field with default of True actually defaults to False when using QueryDict HOT 4
- Support union types and maybe other corner cases HOT 3
- Adding support for dataclass Union field HOT 8
- Mypy error: Type argument "X" of "DataclassSerializer" must be a subtype of "Dataclass" HOT 3
- Bug with @swagger_auto_schema in drf-yasg HOT 1
- Support for types like frozenset? HOT 8
- Serializer initializing dataclass with non init fields
- Why lock on dataclass?
- DataclassListSerializer can't deserialize objects HOT 2
- DataclassSerializer fails with `source="*"` embedded serialiser fields because it requires Meta.dataclass HOT 7
- Implement strict de-serialization option HOT 3
- Version 1.3.0 wheel package is missing `py.typed` file HOT 2
- Populate help_text on serializer HOT 4
- PEP 695 type alias support
- `django-stubs` breaks type checking of `DataclassSerializer.validated_data` HOT 6
- [Feature request] Use `typing.Annotated` to redefine field types HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from djangorestframework-dataclasses.