GithubHelp home page GithubHelp logo

"clear" not working about maccy HOT 3 CLOSED

p0deje avatar p0deje commented on August 26, 2024
"clear" not working

from maccy.

Comments (3)

thewisenerd avatar thewisenerd commented on August 26, 2024

this "works", not sure if correct though:

in Menu.swift

   func clear() {
+    for item in historyItems {
+        removeItem(item)
+    }
     historyItems.removeAll()
   }

from maccy.

thewisenerd avatar thewisenerd commented on August 26, 2024

also, I noticed that we have one NSMenu and historyItems is inserted into it; if we want to implement #26 or #40, we should ideally have history as a separate "submenu" so we can call NSMenu.removeAll()?
disclaimer: I am not aware of Swift or AppKit conventions, so, 🧂

from maccy.

p0deje avatar p0deje commented on August 26, 2024

Thanks for the bug report and the proposed fix!

also, I noticed that we have one NSMenu and historyItems is inserted into it; if we want to implement #26 or #40, we should ideally have history as a separate "submenu" so we can call NSMenu.removeAll()?

I am not sure if submenu works in this case as it might be shown as a single item that expands to submenu items when hovered (e.g. on screenshot)
Screenshot 2019-10-28 at 13 01 07

Otherwise, If that's not true, I think it's a great idea that will simplify things so much.

from maccy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.