Comments (7)
@jkowalleck yeah you are right, it is a duplicate. Shame on me 🙈
I'm currently creating the stubs files. So worst case I will create a PR in typeshed
and best case I will change them to type annotation directly in the project.
from packageurl-python.
@gruebel @jkowalleck Adding typing is fine and likely best done here rather than elsewhere in separate stubs. PR welcomed!
from packageurl-python.
I thank you so much for your effort, @gruebel
from packageurl-python.
i support the request. @madpah FYI
this request might be a duplicate to #65
from packageurl-python.
@pombredanne how do you feel about the topic?
i mean, we do have 3 options:
- adding typing here in the project in code -- generally preferred
- adding typing here in the project as stubs -- okay-ish
- adding typing for PURLs in the python/typeshed as stubs -- if yo do not like type hints but the community wants them anyway.
from packageurl-python.
@pombredanne I created an initial PR #101 would be great to get some feedback. Don't be surprised about me changing variable names. I had to do it, because of type changes in the code. If you have any questions, just add some comments, then I will try to explain, why I had to do it like that.
from packageurl-python.
Implemented in #101, thanks @gruebel !
from packageurl-python.
Related Issues (20)
- Confusing code formatting requirements HOT 3
- Promote version 0.11 from 0.11.0rc1 HOT 3
- Add 'gem' route for purl2url HOT 1
- Return empty purl fields in purl_to_lookups
- Fails to return the version if dependencies are specified HOT 1
- Normalize for qualifiers HOT 5
- Add support for RPM distros in url2purl and purl2ulrl HOT 1
- Add support for bitbucket and gitlab in purl2url to get download URLs HOT 1
- purl.fyi: Convert all purl to URLs seamlessly HOT 1
- no proper release in GitHub for version 0.11.2 HOT 1
- Should PyPI Purl Versions have `_` replaced with `-` (like Name) HOT 1
- Incorrect parsing for PURLs without names HOT 2
- Provide support for Gitlab versioning HOT 1
- Parsing regression for Golang in 0.12.0 release HOT 1
- Improve support for SourceForge URLs HOT 1
- May be vulnerable to `npmjs.evil.com`, `evilpython.org`, `evilsourceforge.net` and more HOT 1
- Add support for additional packages in purl2url HOT 10
- [Discussion] Sourceforge download patterns HOT 1
- Github tags/releases with a `/` in the prefix
- Creation PackageURL objects for invalid PURLs / Possible improper encoding of colons (":") in PURL fields HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from packageurl-python.