GithubHelp home page GithubHelp logo

Comments (7)

gruebel avatar gruebel commented on May 30, 2024 2

@jkowalleck yeah you are right, it is a duplicate. Shame on me 🙈

I'm currently creating the stubs files. So worst case I will create a PR in typeshed and best case I will change them to type annotation directly in the project.

from packageurl-python.

pombredanne avatar pombredanne commented on May 30, 2024 2

@gruebel @jkowalleck Adding typing is fine and likely best done here rather than elsewhere in separate stubs. PR welcomed!

from packageurl-python.

jkowalleck avatar jkowalleck commented on May 30, 2024 1

I thank you so much for your effort, @gruebel

from packageurl-python.

jkowalleck avatar jkowalleck commented on May 30, 2024

i support the request. @madpah FYI

this request might be a duplicate to #65

from packageurl-python.

jkowalleck avatar jkowalleck commented on May 30, 2024

@pombredanne how do you feel about the topic?

i mean, we do have 3 options:

  • adding typing here in the project in code -- generally preferred
  • adding typing here in the project as stubs -- okay-ish
  • adding typing for PURLs in the python/typeshed as stubs -- if yo do not like type hints but the community wants them anyway.

from packageurl-python.

gruebel avatar gruebel commented on May 30, 2024

@pombredanne I created an initial PR #101 would be great to get some feedback. Don't be surprised about me changing variable names. I had to do it, because of type changes in the code. If you have any questions, just add some comments, then I will try to explain, why I had to do it like that.

from packageurl-python.

tdruez avatar tdruez commented on May 30, 2024

Implemented in #101, thanks @gruebel !

from packageurl-python.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.