GithubHelp home page GithubHelp logo

issue with ul li in CSS about hacker HOT 8 CLOSED

pages-themes avatar pages-themes commented on June 10, 2024
issue with ul li in CSS

from hacker.

Comments (8)

benbalter avatar benbalter commented on June 10, 2024

@ousia Can you submit some screenshots of what you're describing?

from hacker.

ousia avatar ousia commented on June 10, 2024

@benbalter, here you have the list item from the Hacker theme:

lists-hacker

List item markers are on a different paragraph from the list items themselves.

The Leap Day theme displays markers and list items on the same paragraph:

lists-leap-day

Would it be possible that the Hacker theme uses images for lists markers as shown above?

Many thanks for your help.

from hacker.

ousia avatar ousia commented on June 10, 2024

@benbalter, after the key to #4, I guess a temporary fix might read:

ul li {
  list-style: disc;
}

ul li:before {
    content: none
}

Would you be interested in a PR with those contents?

from hacker.

ousia avatar ousia commented on June 10, 2024

I forgot to show the results:

issue-fixed

from hacker.

benbalter avatar benbalter commented on June 10, 2024

Would you be interested in a PR with those contents?

Yes please!

from hacker.

ousia avatar ousia commented on June 10, 2024

@benbalter, here you have the output from the fixed version:

new-fixed-version

As far as I know, the PR is ready to be merged.

from hacker.

ousia avatar ousia commented on June 10, 2024

Sorry, I clicked on the wrong button.

from hacker.

ousia avatar ousia commented on June 10, 2024

@benbalter, I submitted the pull request that fixes the issue with list items in unordered lists.

I think it is fine to merge it. Or am I missing something?

from hacker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.