GithubHelp home page GithubHelp logo

Comments (10)

vapier avatar vapier commented on July 25, 2024 2

the request is still relevant. does this project accept FRs ?

from hacker.

stale avatar stale commented on July 25, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from hacker.

stale avatar stale commented on July 25, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

from hacker.

PsychoData avatar PsychoData commented on July 25, 2024

I believe this theme already adds these headerlinks to the headers from github (or at least possibly keeps them from the Github page? I'm not certain)

On Github, the headers automatically get a link image that appears when you hover over it, which is useful to right-click and copy the link address directly to that section
image

On this theme's pages, it seems like the anchors are already created, and if you manually find them and create a link to them, they work, like this
https://msportals.xyz/#azure-it-admin-portals
image

Could we possibly add something to let you copy the links directly to a section/header more easily?
It looks like AnchorJS might work, but I am not certain how to integrate it into the theme

from hacker.

vapier avatar vapier commented on July 25, 2024

the request was about the UI side of things which the theme doesn't do

from hacker.

PsychoData avatar PsychoData commented on July 25, 2024

Oh? I thought that since this theme has the anchors created, but other themes don't, that the theme or something it was using is what was creating the anchors

any idea what might be creating the anchors? Since they are already there once I add the theme, I don't think that trying to recreate them again with AnchorJS like I mentioned above would work correctly, since they would be conflicting

from hacker.

PsychoData avatar PsychoData commented on July 25, 2024

wait, I had a bad file - if I remove the Hacker Theme, then my site looks like this and has working header clickable links
image

and the code looks like this, so I'm not sure where the whole <a> element goes once the theme is enabled, but the same anchor appears in the header element directly instead
image

from hacker.

vapier avatar vapier commented on July 25, 2024

those pictures aren't using the hacker theme. see this page as an example of missing UI elements:
https://vapier.github.io/nosig/

from hacker.

PsychoData avatar PsychoData commented on July 25, 2024

That's my point though, when I remove the theme, the automatic clickable links are there
image

but when the Hacker theme is added back, they are gone
image

from hacker.

vapier avatar vapier commented on July 25, 2024

well, sure, the default theme has the clickable links. that's why this issue is filed against the hacker theme which lacks them.

from hacker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.