GithubHelp home page GithubHelp logo

Comments (8)

sophiewigmore avatar sophiewigmore commented on August 29, 2024 1

I am open to removing this entirely. It has never passed and I'm in agreement at this point that it's not super valuable. If you want to take a stab at fixing it and having it run before releasing, I'd support that too, but enough time has gone into trying to fix this that I'm fine to abandon as well.

from jam.

fg-j avatar fg-j commented on August 29, 2024

@sophiewigmore is this failure residual from before your fix?

from jam.

sophiewigmore avatar sophiewigmore commented on August 29, 2024

@fg-j yea, I forgot to close this out. We'll see if the fix worked on the next release 🙇🏻‍♀️

from jam.

github-actions avatar github-actions commented on August 29, 2024

Another failure occurred: https://github.com/paketo-buildpacks/jam/actions/runs/3290525582

from jam.

robdimsdale avatar robdimsdale commented on August 29, 2024

@paketo-buildpacks/tooling-maintainers this looks like an issue with the script that validates the jam version. It failed on multiple runs so I don't think it's a flake:

Run chmod +x "$GITHUB_WORKSPACE/jam"
chmod: changing permissions of '/home/runner/work/jam/jam/jam': Operation not permitted
Error: Process completed with exit code 1.

from jam.

github-actions avatar github-actions commented on August 29, 2024

Another failure occurred: https://github.com/paketo-buildpacks/jam/actions/runs/3290525582

from jam.

robdimsdale avatar robdimsdale commented on August 29, 2024

Interesting. It looks like this job has never passed since it was introduced in jam v1.2.0.

Given it runs after the release is created, I don't think it's particularly valuable. At best it can tell us that we just shipped a broken version of jam.

In practice, I don't think we've ever seen a release of jam where the version was incorrect, so I would advocate removing this job entirely.

If we want this job to exist, I think it should come before we release, not after.

@paketo-buildpacks/tooling-maintainers I'm happy to take a pass at this, but I'd like feedback on whether we want to fix the job (and move it pre-release) or remove it entirely.

from jam.

robdimsdale avatar robdimsdale commented on August 29, 2024

I'd rather just remove it. We've not any issues in the past with this feature, so I have high confidence in it continuing to work without this type of validation.

I'll open a PR to remove it.

from jam.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.