GithubHelp home page GithubHelp logo

Drag 'n Drop example is broken about flyd HOT 2 CLOSED

hbarcelos avatar hbarcelos commented on July 30, 2024
Drag 'n Drop example is broken

from flyd.

Comments (2)

nordfjord avatar nordfjord commented on July 30, 2024

This has to do with takeUntil

const s1 = stream(1)
const s2 = stream(2)

const s3 = takeUntil(s1, s2)

s3().end() // true

The stream is immediately ended if s2 has a value

Internally in the switch-latest module we use

const dropCurrentValue = flyd.transduce(R.drop(1));

To drop 1 value from the stream to prevent this.

A more comprehensive fix is included in #175, but since the fix is not dependent on the rest of the changes in #175 I might just pop it out of there and make another PR for that.

The fix there is in the takeUntil module:

const dropCurrentValue = flyd.transduce(drop(1));
function takeUntil(src, term) {
  const end$ = flyd.merge(term.hasVal ? dropCurrentValue(term) : term, src.end);
  // ...
}

from flyd.

hbarcelos avatar hbarcelos commented on July 30, 2024

Thank's a lot @nordfjord. Will this PR be merged any time soon?

from flyd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.