Unable to override `authorization_namespace` about action_policy-graphql

[Tyflomate]

It is a classic RoR implementation of graphql. It is hard to give you a code example since it is a private repository :/ I tried overriding it in BaseMutation/BaseObject/ApplicationController(root of my graphql controller) classes. I put a pry inside each of my implementations but none was reached. In each of these classes i just did this:

def authorization_namespace
     ::UserApplication
end

If we have for example a policy like this: UserApplication::TotoPolicy.
I also put a pry inside the library to see the output of this method but for a mutation Mutations::UserApplication::TestMutation, it would always return Mutations::UserApplication.

[Tyflomate]

It may be good to notice that in BaseMutation and BaseObject I have included include ActionPolicy::GraphQL::Behaviour

[Tyflomate]

Sorry didn't have the time to work again on this issue, but we might try again in another context we we'll see the result

[palkan]

Could you please provide a code example? Where do you include Action Policy behaviour and where do you override (and how) #authorization_namespace? I will try to reproduce it

[palkan]

Thanks for the details! (And sorry for late response)

I will do my best to work on this till the end of the year 🙂

[palkan]

@Tyflomate I tried to reproduce the problem here but with no luck: 58e89be

Maybe, you can try to tweak our test examples to demonstrate the failing case?

[palkan]

Hey @Tyflomate! Was this issue resolved? And if not, could you please help with the reproduction (see the prev comment)?

[gael-ian]

Hello @palkan

I encountered the same problem yesterday, maybe in another form.

Our environment is pretty much the same as @Tyflomate. To deduplicate behaviour declaration between our GraphQL types and mutations, I used an ActiveSupport::Concern to include in both base mutation and base object.

So far, it looks like:

module Authorizations
  extend ActiveSupport::Concern

  included do
    include ActionPolicy::GraphQL::Behaviour
    prepend LookupMethods
  end

  module LookupMethods
    def authorization_namespace = ::Api
    def default_authorization_policy_class = ::ApiPolicy
  end
end

We need to use prepend or lookup methods declared in action_policy/behaviours/namespaced.rb take precedence over our version of authorization_namespace.

On the other side, default_authorization_policy_class works however we define it: prepended, included or extended. I would have expected authorization_namespace to work the same.

[palkan]

Hey @gael-ian!

Thanks for the snippet.

I see what's going on here: we define the #authorization_namespace method right on the class:

action_policy-graphql/lib/action_policy/graphql/behaviour.rb

Line 25 in 58e89be

def base.authorization_namespace

That's why include doesn't work.

Agree, this is confusing, let's fix it.

[palkan]

Nope, the code I linked above only affects authorized? callbacks—is this your case @gael-ian ? Otherwise, overriding #authorization_namespace works fine, see f0129eb

[palkan]

Okay, thanks; closing for now; will re-open if the problem occurs again.