Comments (6)
Makes sense. I'll take a closer look later this week, @dmills-yesware thanks for pointing this out!
from logidze.
When you call p.comments.length
the comments
association is not loaded yet, so we try to load it and rewind the state calling the #at
method.
And it fails since the ignore_log_data
is true for the Comment.
You need to use with_log_data
here as well, i.e. p.comments.with_log_data.length
.
Which seems confusing.
@DmitryTsepelev Maybe, we should apply with_log_data
to associations automatically if log_data
is defined for the owner?
from logidze.
Thanks for the quick response!
You need to use with_log_data here as well, i.e. p.comments.with_log_data.length
Ah, excellent. I had tried that, but not before first trying to load comments
on the instance without using with_log_data
.
[34] pry(main)> p.comments.length
ActiveModel::MissingAttributeError: missing attribute: log_data
from /Users/dmills/.rvm/gems/ruby-2.3.5@yesware/gems/activerecord-4.2.10/lib/active_record/attribute_methods/read.rb:93:in `block in _read_attribute'
[35] pry(main)> p.comments.with_log_data.length
ActiveModel::MissingAttributeError: missing attribute: log_data
from /Users/dmills/.rvm/gems/ruby-2.3.5@yesware/gems/activerecord-4.2.10/lib/active_record/attribute_methods/read.rb:93:in `block in _read_attribute'
As long as the first attempt to load the relation includes with_log_data
then it works:
[40] pry(main)> Post.with_log_data.last.at(time: Time.now).comments.with_log_data.at(time: Time.now).length
=> 3
Worth noting: It does appear that I need to repeat the at
on the comments
relation in order to get the correct historical view of the comments
at the same point in time as the Post
. That's probably expected with the way things are built, but it might also be cool if the API were made to load the relation using the same with_log_data
and at
setting as the parent model, so that it's seamless.
Thanks again.
from logidze.
It does appear that I need to repeat the at on the comments relation in order to get the correct historical view of the comments at the same point in time as the Post. That's probably expected with the way things are built
Looks like a bug. Associations should inherit the at
value automatically.
from logidze.
@dmills-yesware FYI I think I have a solution as a part of my ongoing PR - I decided to avoid making a separate one because that PR touches ignore_log_data
codebase a lot
from logidze.
Fixed in 0.10.0, @palkan I guess we can close this issue
from logidze.
Related Issues (20)
- How to list all versions of a record? HOT 4
- Association versioning with ignore_log_data and at(version: ) doesn't return expected results HOT 5
- Partition-friendly logging (triggers) HOT 3
- JSONB column and switch_to! with append: true HOT 2
- PG::UndefinedFunction: ERROR: function hstore(model_name) does not exist HOT 1
- Meta per request HOT 1
- Logidze.ignore_log_data_by_default causing db:migrate errors HOT 2
- Responsible from different sources HOT 3
- Associations versioning - accessing versions with `at(version: #)` HOT 2
- How to tell logidze about a new column HOT 8
- GlobalID support for metadata
- `responsible_id` is not updated on relation with `touch: true` HOT 6
- reload_log_data doesn't work when used with acts_as_paranoid and deleted records HOT 2
- docs: logdize cannot set session meta data when using a connection pool HOT 1
- How can I get the last 100 versions of a model? regardless of the record HOT 2
- Saving log with only metadata changes HOT 1
- Not possible to use latest logidze and anyway_config with Ruby 3.3.0 HOT 1
- Make Sequel support independent from ActiveRecord and ActiveSupport
- Updating history when column names change HOT 3
- Filter by changed attrs HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from logidze.