Missing crates not downloaded when syncing mirror about panamax

[k3d3]

Yep, that should give the ability for people to make sure any missed crates get downloaded, so hopefully that solves the issue for most people. I'll close the issue - feel free to bump/reopen this issue if it still persists.

[k3d3]

I closed it as I had no feedback from you. But I decided to still open an issue about it.

Oh shoot. Apparently I don't know how to use Github PRs - I had left feedback in a review, but I think because I hadn't finalized the review, the comments didn't show up.

[JamesMConroy]

I'm facing the same issue, specifically with cargo-make. There was a new release for that project, but panamax is unable to grab it.

[ricked-twice]

Sorry, just saw your answer, didn't get any notification weirdly !
Do you want me to submit a PR again or should I try to add another feature to download missing crates ?

[k3d3]

No worries at all! Yes, please do go ahead and reopen the PR, and I'll make a review on it.

Thank you!

[JamesMConroy]

Can you just reopen #57 instead of creating a whole new pull request?

[k3d3]

Sure thing!

[ricked-twice]

I modified the current state of the old PR regarding your comments.

Regarding download of missing crates, I think it would be better to first add a feature to download one specific crates, and then an option could be added to verify to download the missing crates after asking user validation and possibly two other options: assuming yes to user validation for downloading missing crates and maybe a dry-run option too.
For example:

# Would ask for user validation before download if any missing crates
panamax verify --fix /path/to/mirror
# Not asking anything here
panamax verify --fix --assume-yes /path/to/mirror
# Just checking mirror state
panamax verify --dry-run /path/to/mirror

What do you think about it?

[JamesMConroy]

Looks like #57 is merged. Does everyone think that resolves this issue?

[ricked-twice]

Just to be clear I did not added the feature yet, I was waiting for any comment about my last comment which was a suggestion and a proposition to do it, if it was interesting you.

Anyway, I'll try to do it in next few days.