GithubHelp home page GithubHelp logo

New Style Rule: forceValue about esthetic HOT 2 CLOSED

panoply avatar panoply commented on May 26, 2024
New Style Rule: forceValue

from esthetic.

Comments (2)

panoply avatar panoply commented on May 26, 2024

Thinking about this more and don't believe it's the right direction to allow all selector property values be indented onto new lines, but instead a much better option is to make this Liquid specific, meaning only Liquid tokens are newlined. I will ship the pre-release with such logic supported and await to see users feedback on extending the ruleset for all property values.

from esthetic.

panoply avatar panoply commented on May 26, 2024

Defect Introduced

This experimental ruleset ended up introducing a major defect in the style parser and will be removed in next patch. It was interesting to explore this option, especially in Liquid but it should be avoided.

Reasonings

This beautification approach was initially discussed between myself and @toklok - the goal to bring uniform in styles that are conditionally applying style values with Liquid syntax. The first few POC's seemed worthwhile but after some time of running E2E tests it seems the juice is not worth the squeeze.

from esthetic.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.