Comments (2)
Thinking about this more and don't believe it's the right direction to allow all selector property values be indented onto new lines, but instead a much better option is to make this Liquid specific, meaning only Liquid tokens are newlined. I will ship the pre-release with such logic supported and await to see users feedback on extending the ruleset for all property values.
from esthetic.
Defect Introduced
This experimental ruleset ended up introducing a major defect in the style parser and will be removed in next patch. It was interesting to explore this option, especially in Liquid but it should be avoided.
Reasonings
This beautification approach was initially discussed between myself and @toklok - the goal to bring uniform in styles that are conditionally applying style values with Liquid syntax. The first few POC's seemed worthwhile but after some time of running E2E tests it seems the juice is not worth the squeeze.
from esthetic.
Related Issues (20)
- Isolated Liquid attributes applying quote conversion
- Delimiter defect when singular Liquid output token HOT 1
- Improve handling of SVG nodes
- Ignoring Regions with {% # @prettify-ignore-start %} not working HOT 2
- Liquid + html comment formatting not indenting as expected
- CSS/JS formatting, brackets unexpected behavior HOT 3
- {% # @prettify-ignore %} adds a bracket or a new line at the end of file HOT 1
- Formatting of multiline liquid tags HOT 1
- Improve Text (content) handling HOT 1
- JSON formatting issue HOT 4
- Improve parse error information HOT 1
- New Markup Rule: valueForce HOT 1
- Support Bad Liquid HOT 1
- Support SVG Voids HOT 2
- Changing module name to Æsthetic
- Tree shaking HOT 2
- Comment defects and Improvement
- Empty Conditionals
- Better handling for Liquid Captures
- Support Liquid Line Comment Ignores HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from esthetic.