GithubHelp home page GithubHelp logo

Comments (4)

danielbachhuber avatar danielbachhuber commented on August 16, 2024

Hm. I don't know how I feel about catching all Redis exceptions. Right now, we're just catching those we think we know how to safely handle.

What exception are you seeing in the real world that you'd rather catch than retry?

from wp-redis.

jtsternberg avatar jtsternberg commented on August 16, 2024

'read error on connection' is definitely one (which I'm adding via the filter now). I'm just not sure fataling the site is a better alternative to... something else.

from wp-redis.

danielbachhuber avatar danielbachhuber commented on August 16, 2024

Ok. Note, you'll need to add your filter to sunrise.php in order for it to apply, as a mu-plugin will be too late.

from wp-redis.

jtsternberg avatar jtsternberg commented on August 16, 2024

Another spot which needs some try/catch/reconnection:

[17-Nov-2015 22:12:59 UTC] PHP Fatal error:  Uncaught exception 'RedisException' with message 'Redis server went away' in D:\home\site\wwwroot\wp-content\plugins\wp-redis\object-cache.php:711
Stack trace:
#0 D:\home\site\wwwroot\wp-content\plugins\wp-redis\object-cache.php(711): Redis->auth('ymTsuP1OTa/ydbc...')
#1 D:\home\site\wwwroot\wp-content\plugins\wp-redis\object-cache.php(838): WP_Object_Cache->_connect_redis()
#2 D:\home\site\wwwroot\wp-content\plugins\wp-redis\object-cache.php(135): WP_Object_Cache->__construct()
#3 D:\home\site\wwwroot\wp-includes\load.php(449): wp_cache_init()
#4 D:\home\site\wwwroot\wp-settings.php(86): wp_start_object_cache()
#5 D:\home\site\wwwroot\wp-config.php(123): require_once('D:\\home\\site\\ww...')
#6 D:\home\site\wwwroot\wp-load.php(37): require_once('D:\\home\\site\\ww...')
#7 D:\home\site\wwwroot\wp-login.php(12): require('D:\\home\\site\\ww...')
#8 {main}
  thrown in D:\home\site\wwwroot\wp-content\plugins\wp-redis\object-cache.php on line 711

from wp-redis.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.