Comments (4)
Hm. I don't know how I feel about catching all Redis exceptions. Right now, we're just catching those we think we know how to safely handle.
What exception are you seeing in the real world that you'd rather catch than retry?
from wp-redis.
'read error on connection' is definitely one (which I'm adding via the filter now). I'm just not sure fataling the site is a better alternative to... something else.
from wp-redis.
Ok. Note, you'll need to add your filter to sunrise.php
in order for it to apply, as a mu-plugin will be too late.
from wp-redis.
Another spot which needs some try/catch/reconnection:
[17-Nov-2015 22:12:59 UTC] PHP Fatal error: Uncaught exception 'RedisException' with message 'Redis server went away' in D:\home\site\wwwroot\wp-content\plugins\wp-redis\object-cache.php:711
Stack trace:
#0 D:\home\site\wwwroot\wp-content\plugins\wp-redis\object-cache.php(711): Redis->auth('ymTsuP1OTa/ydbc...')
#1 D:\home\site\wwwroot\wp-content\plugins\wp-redis\object-cache.php(838): WP_Object_Cache->_connect_redis()
#2 D:\home\site\wwwroot\wp-content\plugins\wp-redis\object-cache.php(135): WP_Object_Cache->__construct()
#3 D:\home\site\wwwroot\wp-includes\load.php(449): wp_cache_init()
#4 D:\home\site\wwwroot\wp-settings.php(86): wp_start_object_cache()
#5 D:\home\site\wwwroot\wp-config.php(123): require_once('D:\\home\\site\\ww...')
#6 D:\home\site\wwwroot\wp-load.php(37): require_once('D:\\home\\site\\ww...')
#7 D:\home\site\wwwroot\wp-login.php(12): require('D:\\home\\site\\ww...')
#8 {main}
thrown in D:\home\site\wwwroot\wp-content\plugins\wp-redis\object-cache.php on line 711
from wp-redis.
Related Issues (20)
- Implement `wp_cache_supports` function HOT 2
- many php warnings in my logs HOT 2
- CircleCI is not configured correctly HOT 4
- When `$wp_object_cache->is_redis_connected` is `false` there is a fatal error for `$missing_redis_message` HOT 4
- [BUGS-5944] Command "wp redis cli" fails HOT 1
- Fix some docblocks
- [BUGS-6118] PHP Deprecation notice on passing port = null @ Redis::connect() HOT 5
- As of WordPress 6.1 A Notice About Incorrect Support for `wp_cache_flush_runtime` HOT 8
- Re-add wordpress-upstream-tests to behat tests
- Fatal error in WP-CLI when accessing cache HOT 3
- esc_html is not safe to use (exception loop) HOT 3
- Implement PHPUnit and/or Behat tests for WP-CLI
- [BUGS-6318] file_exists(): open_basedir restriction in effect. HOT 9
- PHP 8.2 compatibility HOT 1
- [CMSP-467] Please don't strip all tags from the cache password. HOT 2
- [CMSP-470] Replace use of wp_strip_all_tags (possibly any wp filter function?) in object-cache.php
- Changes Merged from #360 Break Redis Connections on Pantheon Due to #400 and Incorrect array_replace_recursive call
- Large response size HOT 2
- [BUGS-6457] Warning when using tls protocol HOT 3
- PHP 8.1 deprecated warning
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wp-redis.