Compatibility with Batcache? about wp-redis

[danielbachhuber]

Compatible in what sense? It should be fine to run the two side by side.

[szepeviktor]

Maybe: Will Batcache put pages in wpcache thus in redis?

[phone]
Ezen a készüléken nehéz gépelni.
Elnézést!

On April 7, 2016 1:35:46 PM CEST, Daniel Bachhuber [email protected] wrote:

Compatible in what sense? It should be fine to run the two side by
side.

---

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#80 (comment)

[tlovett1]

Here is the error I'm getting:

Fatal error: Call to undefined function add_action() in /srv/www/trunk/wp-content/object-cache.php on line 1087

Clearly, Batcache is instantiating WP_Object_Cache before add_action is available. I can fix if you guys want.

[danielbachhuber]

Clearly, Batcache is instantiating WP_Object_Cache before add_action is available.

Huh.

I can fix if you guys want.

What do you think the fix should be?

[tlovett1]

https://github.com/WordPress/WordPress/blob/master/wp-settings.php#L74

advanced-cache.php is included before things like $wpdb or add_action() are defined.

[tlovett1]

The fix is getting rid of the "failback" flush as well as the admin notice error. If you guys are interested, I can create a PR.

[danielbachhuber]

The fix is getting rid of the "failback" flush as well as the admin notice error.

Er, removing a feature isn't really a fix. We'll need to find some other workaround.

[danielbachhuber]

Similar to how Batcache does it, we can inject our action instead on the $wp_filter global: https://github.com/Automattic/batcache/blob/master/advanced-cache.php#L540

Alternatively, because the object cache is always re-initialized after advanced-cache.php runs, we could just have safety checks for add_action() and $wpdb being defined.

[danielbachhuber]

@tlovett1 Can you see if #81 works for your needs?

[josephabrahams]

Works like a charm!

[danielbachhuber]

🔨