paoloruiz / ootp-pt-analysis

ootp-pt-analysis

How to generate a sheet - run python generate_sheet.py in the terminal and check the output folder.

To add columns to different sheets, see the analysis_sheet_headers.py file in the output_utils folder

To see how calculating babip works, look at the calculate_babip.py file.

ootp-pt-analysis's Issues

Lefty/righty copy/paste errors

calculate_splits.py is riddled with copy/paste errors; particularly I noticed these in lines 27-34. I'll submit a pull request with this fix as well as a fix for the divide-by-zero issues I've been getting.

Divide by zero error in calculate_stats.py

Traceback (most recent call last):
File "C:\Users\johnm\Dropbox\ootp-pt-analysis\generate_sheet.py", line 47, in
splits = get_splits(ovr_data_ylt, vl_data_ylt, vr_data_ylt, vl_data, vr_data)
File "C:\Users\johnm\Dropbox\ootp-pt-analysis\stats\splits\calculate_splits.py", line 8, in get_splits
"fielder": sum(map(lambda gs_stats: gs_stats["gs"], fielder_full_time)) / len(fielder_full_time),
ZeroDivisionError: division by zero

I assume someone in one of my tournaments got used only as a DH, PH or PR and thus had no fielding data.
Easy enough to fix with "0 if len(variable)==0 else (quotient)", but has to be fixed for each fielding data line and catching line.

KeyError in calculate_stats

Traceback (most recent call last):
File "C:\Users\johnm\Dropbox\ootp-pt-analysis\generate_sheet.py", line 47, in
splits = get_splits(ovr_data_ylt, vl_data_ylt, vr_data_ylt, vl_data, vr_data)
File "C:\Users\johnm\Dropbox\ootp-pt-analysis\stats\splits\calculate_splits.py", line 2, in get_splits
catcher_full_time, catcher_vr, catcher_vl = _get_potential_catchers(ovr_data, vl_data_ylt, vr_data_ylt)
File "C:\Users\johnm\Dropbox\ootp-pt-analysis\stats\splits\calculate_splits.py", line 64, in _get_potential_catchers
if vl_data[year_league_team][pot_catchers[0]["CID"]]["gs"] > vl_data[year_league_team][pot_catchers[1]["cid"]]["gs"]:
KeyError: 'cid'

Fix is to change "cid" to "CID". PR incoming.