GithubHelp home page GithubHelp logo

Comments (4)

456dev avatar 456dev commented on May 27, 2024

i've just tested without fabric (directly patching vanilla minecraft itself, see this fork of mache)
and was able to add and receive a custom configuration task both with and without velocity, with no changes.

i dont know what fabric does differently (thats next for me to test), but this doesn't seem like a velocity issue?

from velocity.

electronicboy avatar electronicboy commented on May 27, 2024

The start and the end of the configuration phase are both well marked with two separate packets, and so there's no need for velocity to care about custom configuration phases as we just wait on the server to tell us when its done configuring the client before we can proceed with actually bumping the client out of that phase.

I'm not really sure what MM is doing here, their repo is pre configuration phase existing, and they're not doing anything in their existing repo that would break with a proxy.

from velocity.

456dev avatar 456dev commented on May 27, 2024

ive found the issue, its on MightyMails side (sort of). it uses MrCrayfish/Framework, which uses login plugin messages on <1.20.2 (which makes sense, as the config phase didnt exist before then anyway.)

from velocity.

electronicboy avatar electronicboy commented on May 27, 2024

Yea, login messages are 100% a no-go until 1.20.5, in which at that point we miiiight be able to get something that will support that stuff a bit better (but, is a chunky engineering effort I want to get to but can't really commit to...)

from velocity.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.