GithubHelp home page GithubHelp logo

Comments (11)

Wicpar avatar Wicpar commented on June 3, 2024

it's possible there was a regression

from ktor-openapi-generator.

RamsesGomez avatar RamsesGomez commented on June 3, 2024

Any suggestion? An idea of what should we change?

from ktor-openapi-generator.

Wicpar avatar Wicpar commented on June 3, 2024

do you have an implementation I can test to reproduce ?

from ktor-openapi-generator.

RamsesGomez avatar RamsesGomez commented on June 3, 2024

when you said "It's possible there was a regression" what do you really mean by this? We are following the exact same example you have with the exception that we have both unauthorized routes and authorized ones.
Maybe that helps. Unfortunately I do not have an implementation for you to test.

from ktor-openapi-generator.

Wicpar avatar Wicpar commented on June 3, 2024

can you send the openapi.json ?
Have you tried the openapi.json on Redoc, it is has a better implementation of the standard.
A commit between *.14 and *.18 changed the definition as it was not coherent with the standard.
The regression would be in the library, as a few PRs have been accepted since.

from ktor-openapi-generator.

Wicpar avatar Wicpar commented on June 3, 2024

@RamsesGomez I just tested the JWT test and it has the authorization as expected... I did update a few libraries though, let me wrap that up so you can try.

from ktor-openapi-generator.

Wicpar avatar Wicpar commented on June 3, 2024

@RamsesGomez try the latest release and tell me if it works

from ktor-openapi-generator.

RamsesGomez avatar RamsesGomez commented on June 3, 2024

@Wicpar Awesome let me try thanks a lot for the swift response

from ktor-openapi-generator.

RamsesGomez avatar RamsesGomez commented on June 3, 2024

I tested it but no luck I can see that the new generated json looks like this:

"security": [ { "entries": [ null ], "keys": [ "jwtAuth" ], "size": 1, "values": [ [ "Dummy" ] ] } ],

where as the old one looked like this:

"security": [ { "jwtAuth": [ "Dummy" ] } ],

from ktor-openapi-generator.

RamsesGomez avatar RamsesGomez commented on June 3, 2024

You mentioned you have an example that worked is it possible to see that sample?

from ktor-openapi-generator.

RamsesGomez avatar RamsesGomez commented on June 3, 2024

Ok We found the problem... we have a custom serialization module to be able to use kotlin serialization, and the SecurityModel now is a Map and that was the problem, all DataModel were being serialized differently but now is all good thanks a lot for the support much appreciated

from ktor-openapi-generator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.