GithubHelp home page GithubHelp logo

Comments (8)

pardeike avatar pardeike commented on May 23, 2024

Please try cloning master, then choose HarmonyFat and right click Harmony project and choose Pack. Use the NuGet package that builds in Harmony/bin locally (point your own projects nuget settings to its directory as an extra nuget source and move it up in priority) or use the 0Harmony.dll in the corresponding .net version folder.

The master contains changes on how dependencies are internalized. If that does not solve your problem you can try the existing Lib.Harmony.Thin nuget package and supply all dependencies yourself.

Let me know if this solves your problem. I am about to release Harmony and the way it’s build is currently actively discussed on the official discord (beta channel).

from harmony.

jichulu avatar jichulu commented on May 23, 2024

Looks like the latest version has been fixed.

image

from harmony.

pardeike avatar pardeike commented on May 23, 2024

Is the screenshot from Thin or Fat?

from harmony.

jichulu avatar jichulu commented on May 23, 2024

Is the screenshot from Thin or Fat?

Both.
image

from harmony.

pardeike avatar pardeike commented on May 23, 2024

My question is: which, fat or thin, did solve your problem?

from harmony.

jichulu avatar jichulu commented on May 23, 2024

My problem occurs in version 2.3.0-prerelease.7. clone code from GitHub can solve the CS0433 error thrown during compilation.
But when running the program, the Mono.Cecil reference cannot be found. When switched to ReleaseFat mode to compile, but the compilation failed: ILRepack.targets error : Failed to resolve System.Reflection.BindingFlags.
After consulting the information about ILRepack, I learned that it is a tool for merging 3rd dlls. Considering that its behavior is to merge through IL reorganization, there may be a risk of damaging related 3rd dlls. So I used the NuGet package Costura.Fody instead. After compilation, referenced the local NuGet package and runs OK.
The relevant changes are as follows:

<PropertyGroup Condition="'$(Configuration)'=='DebugThin' Or '$(Configuration)'=='ReleaseThin'">
	<!-- Disable to merge external dll -->
	<DisableFody>true</DisableFody>
</PropertyGroup>

<ItemGroup>
	<PackageReference Include="Costura.Fody" Version="5.7.0" PrivateAssets="all"/>
	<PackageReference Include="MonoMod.Core" Version="$(MonoModCoreVersion)" PrivateAssets="all" />
	<!-- Reference assemblies are needed for non-Windows .NET Framework targeting builds. -->
	<PackageReference Include="Microsoft.NETFramework.ReferenceAssemblies" Version="1.0.3" PrivateAssets="all" />
</ItemGroup>

The first part of the PropertyGroup configuration is used to prohibit merging third-party dlls in thin mode.
The second part is to remove ILRepacker and use Costura.Fody instead.
Costura.Fody packages third-party dlls as embedded resources and loads them at runtime. This approach will not change third-party dlls, especially signed dlls.

from harmony.

pardeike avatar pardeike commented on May 23, 2024

Costura.Fody has a very questionable license model so I rather not want to use it.

from harmony.

pardeike avatar pardeike commented on May 23, 2024

@jichulu You should try master instead of prerelease 7

from harmony.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.