`EventStream` doesn't handle dropped connections about particle-api-js

[monkbroc]

Thanks for the reproduction steps. It will make it easier to look into this issue.

[ricott]

Any plans to solve this bug or any ideas on how I can work around it myself and check if connection is open or not?

[khpeterson]

+1 on this issue. For me the issue boils down to errors from EventStream.req after the stream has connected/the promise has been resolved. The call to reject that is registered with req.on('error'...) does nothing because the promise has already been resolved and so the errors fall on the floor. To work around this I'm re-registering my own EventStream.req error handler in the resolve function but obviously it would cleaner to do this inside EventStream.js. I will create a pull request.

[monkbroc]

The work in progress PR is here if you want to test it: #99

[khpeterson]

Thank you for the pointer, I reviewed EventStream.js and it looks good to me / addresses the issue I've been fighting. I will test it in my environment too. Any idea on when this version will end up in cdn.jsdelivr.net?

[monkbroc]

I'd like to test the changes on console.particle.io and the Particle CLI. For the version, it looks like a major version bump because if user code depends on the detailed implementation of the event stream, it might break.

…

On Fri, May 17, 2019 at 12:23 PM Kevin Peterson ***@***.***> wrote: Thank you for the pointer, I reviewed EventStream.js and it looks good to me / addresses the issue I've been fighting. I will test it in my environment too. Any idea on when this version will end up in cdn.jsdelivr.net? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#95?email_source=notifications&email_token=AAOUVQJECYNHDBWZFJFSU2LPV3LWJA5CNFSM4FS7UKWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVVG3HA#issuecomment-493514140>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAOUVQOSTWYEBQWNIXIUI43PV3LWJANCNFSM4FS7UKWA> .

[monkbroc]

This is now available in version 8.0.0 of particle-api-js