Dictionary<string,object> deserialization problem about nservicebus

[udidahan]

We don't want to support/encourage the use of untyped data in message schema.
Can you explain what information your moving around here and what the context of the message is?

[fvuksan]

Hi,
I have generic message class that contains three common parameters with specific meaning and dictionary for all other needs. I suppose I could use inheritance and name all parameters but I obviously didn't :-). Anyway, using dictionary should be either explicitly forbidden or fixed. This way it just doesn't work and that is confusing.

[udidahan]

Dictionaries are supported - it's just that generics of object aren't. For example, you can use Dictionary of string and string.

[fvuksan]

I just wanted to point out that Dictionary of string and object serialization works and deserialization fails silently. However you look at it, that isn't good behaviour.

[fvuksan]

Sorry, I pressed wrong button.

[andreasohlund]

Udi: What should we do here ? a better exception?

[udidahan]

Yes, a better exception - I think we can generalize the check to yell about anything which is of the type "object".

[andreasohlund]

Joseph:

Add a test: When_serializing_a_property_with_idictionary_object
It should throw an exception saying that its not supported

And make the above change

[Jpattom]

For IDictionary the Test and Exception is already there
Here is the Log
[exec] Errors and Failures:
[exec] 1) Test Error : NServiceBus.Serializers.XML.Test.SerializerTests.Comparison
[exec] System.NotSupportedException : IDictionary<T, K> is not a supported property type for serialization, use
Dictionary<T,K> instead. Type: NServiceBus.Serializers.XML.Test.IM2 Property: AnyFoos. Consider using a concrete Dictionary<T, K> instead.

Do we need same kind of exception while using Dictionary<object, object> ?

[andreasohlund]

Yes, Dictionary<string,string> is supported, it's the use of "object" that is not supported.
Add the following test:
When_using_a_dictionary_with_an_object_key_or_value
It Should throw an exception telling the user that untyped dictionaries is not supported
/Andreas

http://andreasohlund.net

http://twitter.com/andreasohlund

Date: Sat, 13 Aug 2011 23:41:33 -0700
From: [email protected]
To: [email protected]
Subject: Re: [NServiceBus] Dictionary<string,object> deserialization problem (#65)

For IDictionary the Test and Exception is already there
Here is the Log
[exec] Errors and Failures:
[exec] 1) Test Error : NServiceBus.Serializers.XML.Test.SerializerTests.Comparison
[exec] System.NotSupportedException : IDictionary<T, K> is not a supported property type for serialization, use
Dictionary<T,K> instead. Type: NServiceBus.Serializers.XML.Test.IM2 Property: AnyFoos. Consider using a concrete Dictionary<T, K> instead.

Do we need same kind of exception while using Dictionary<object, object> ?

Reply to this email directly or view it on GitHub:
#65 (comment)

[Jpattom]

Please Look for the fix and Unit test cases.

[andreasohlund]

Looks good (I've made a minor comment in the commit)