SEGFAULT when "./microshell cd" about 42-school-exam-rank-04

[pasqualerossi]

How would you implement this protection? What would the code look like?

[Laendrun]

You could add that protection by simply adding a condition to both while loops.

// current code
int	write_error(char *string, char *argv)
{
	while (*string)
		write(2, string++, 1);
	while (*argv)
		write(2, argv++, 1);
	write(2, "\n", 1);
	return (1);
}

// protected code
int	write_error(char *string, char *argv)
{
	while (string && *string)
		write(2, string++, 1);
	while (argv && *argv)
		write(2, argv++, 1);
	write(2, "\n", 1);
	return (1);
}

the added string and argv in the while loop have to come first in the argument list of the while so that it is checked first and if either string or argv is NULL, it won't go into the loop and won't cause a SEGFAULT