after_commit_on_update with multiple updates to the same object per transaction about after_commit

[pat]

Hi Case

To be honest, I don't really use this project at all beyond Thinking Sphinx, and even then, most of my focus is on Rails 3 and newer. So, you're in a better position to make the call about whether this patch should happen. If you want to submit a pull request, please do - if you can add tests for it, even better.

[xaviershay]

I totally just lost the better part of my day to this :(

Will investigate a fix, but I think I'll probably use my time to refactor away our usage of this instead.

[ctaintor]

xaviershay - I ended up just editing my version of after_commit, which was probably not the best thing to do (since it gave you pain), but I knew it worked for our use case and didn't want to worry about someone else's use case. Basically, in after_commit.rb, change add_to_collection to be this:

def self.add_to_collection(collection, connection, record)
  current_collection = Thread.current[collection][connection.unique_transaction_key]
  #Only add to the collection if this specific object isn't already into the collection
  current_collection << record unless current_collection.any?{|existing_record| existing_record.object_id == record.object_id}
end