GithubHelp home page GithubHelp logo

Comments (8)

JosefBredereck avatar JosefBredereck commented on June 2, 2024

The styles are not getting loaded, for the view all pages it is working partially but also not as intended, and for the detail view with the code panel it is not working.

Thanks for highlighting that issue.

from patternlab-node.

mfranzke avatar mfranzke commented on June 2, 2024

To my impression code highlighting just wasn't expected to work / targeted at anything else than the code panels so far. So we most likely only need to decide on whether we want to target for code[class*="language-"] in other contexts as well (mainly the surrounding pattern lab documentation content as well as the description section within the expanded details.

from patternlab-node.

JosefBredereck avatar JosefBredereck commented on June 2, 2024

Even there it is not working.
I tested it myself in the code panels on the view all pages and in the code panels on the detail page.
Both seem not to take the CSS into account. Maybe there was a change down the road where we missed it.

from patternlab-node.

mfranzke avatar mfranzke commented on June 2, 2024

@JosefBredereck maybe I do have a misunderstanding here, but if I do open e.g. https://patternlab-handlebars-preview.netlify.app/?p=all the HTML code gets its highlighting:
image

from patternlab-node.

JosefBredereck avatar JosefBredereck commented on June 2, 2024

Ah, that's what you mean. I mean the left-hand site of that panel, where the .md content gets rendered.

from patternlab-node.

StfBauer avatar StfBauer commented on June 2, 2024

Yes, but not the content of the description.

Take this for example: https://lab.n8d.studio/htwoo/htwoo-core/?p=atoms-grid

image

It has somewhat rendered syntax highlighting, just the 'code' styles but does not tokenise it with primsjs.

<pre><code class="language-css">.demo-item{
	@include gridSpan(4);
}
</code></pre>

from patternlab-node.

mfranzke avatar mfranzke commented on June 2, 2024

Yes, but not the content of the description.

Take this for example: https://lab.n8d.studio/htwoo/htwoo-core/?p=atoms-grid

image

It has somewhat rendered syntax highlighting, just the 'code' styles but does not tokenise it with primsjs.

<pre><code class="language-css">.demo-item{
	@include gridSpan(4);
}
</code></pre>

I still think that's related to the selector & scope that we're using for the code formatter at the moment – this would either need to get added to that selector or – if we are in another component for this section on the left – a JavaScript call of that code formatter would need to get added for <code> parts in that component as well, which most likely currently doesn't exist.

@StfBauer would you be able to contribute a PR for this problem, please?

from patternlab-node.

StfBauer avatar StfBauer commented on June 2, 2024

Sure, but I need some guidance on the project.

from patternlab-node.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.