Remove duplicated pwmetrics object properties and merging yargs support about pwmetrics

[denar90]

Oh, got your point. Make sense.
Lets do it 💪 I'm ok to make it in scope of yargs PR. Jut make PR against yargs branch, so I'll merge it together.

[paulirish]

I suppose this is done, now that we have our combined refactor in place? :)

Pedro, feel free to reopen if we got more here!

[denar90]

SGTM
just one question about #48
What exactly do you wanna improve? Passing flags from confg file?

[pedro93]

I was thinking of populating the pwmetrics object with the properties from the config file in case one exists. If there are repeated parameters both in a config file and from the cmd line, then the cmd line should take precedent.
Imagine something like:

performance.config.js

module.exports = {
    url: "http://github.com",
    json: false,
    runs: 5,
    flags: {
        expectations: true,
    },
    sheets: {
        // sheets configuration
    },
    expectations: {
        ttfmp: {
            warn: '>=3000',
            error: '>=5000',
        },
        tti: {
            warn: '>=5000',
            error: '>=15000',
        },
        ttfcp: {
            warn: '>=1500',
            error: '>=3000',
        },
        psi: {
            warn: '>=3000',
            error: '>=6000',
        },
    },
};

Bash

$ pwmetrics --config="path/to/file.js" --json

The json option in the terminal overrides the config option. A use case for this would be wanting to see results with slightly different options but no having to change the actual file (which you may not have permissions to edit). This would also potentially allow any configuration to be set via the command line that can also be set in the config file.

This logic should be done IMO in the bin/cli.js file after yargs has been merged, hence the dependency.

[pedro93]

@paulirish do you approve? If so I will start working on this. I do have a question though, what is the rationale behind this loop?
https://github.com/paulirish/pwmetrics/blob/master/bin/cli.js#L24

[denar90]

It's redundant from old API. Going with your suggestion we can do smth like `config.flags = Object.assign({}, flagsFromFile, cliFlags)`

…

On Feb 7, 2017 5:26 PM, "Pedro Silva" ***@***.***> wrote: @paulirish <https://github.com/paulirish> do you approve? If so I will start working on this. I do have a question though, what is the rationale behind this loop? https://github.com/paulirish/pwmetrics/blob/master/bin/cli.js#L24 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#53 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AF8V3G8oWeIJ98d0tZJw4hgiknasLQsTks5raI0LgaJpZM4L5h4B> .