Not all layers re-link after changing theme about camilo

[Pausansol]

Please, can you send to me a file with the minimum content (a pair of components and styles) to see what is happening?

[raetones16]

Im having this same issue. The way we work is that we have two theming documents - light and dark theme which feed into a master component library then our product documents are built up of components from the master library and elements which have styles from one of the theming documents applied to them. Within the theming documents the styling names are identical and in the past it has worked a dream with Camillo - however recently when making a switch between themes not all styles are replaced.

Our usual workflow is - switch the theme on the master component library, then update the components within the product document, then switch the theme on the product document and that would be it.

From what i can see its some of the elements that are native to the product document that arent switching. The master components switch fine and then get applied across the document fine. Its really inconsistent with what does update and what doesnt though. Some text styles update ok, others don't, same with colour styles too.

[Pausansol]

Sounds like a weird behaviour. When one layers works and others don't sounds like a difference in the styles names or something like that. I can't replicate what are you saying guys, so I recommend to isolate one example of what is not working and send it to me if it works for you.

[raetones16]

I will try and get you a working example uploaded over the weekend as i'm unable to just share my project files unfortunately. That said though, i'm beginning to think the issue may be on the Sketch side rather than Camillo as i actually also experience issues at times when manually changing between one theme to another on any given element. Sketch essentially either refuses to swap or the style changes but is displayed as an override to the original style that was applied. It's causing me so much wasted time at the minute. Thanks for the response though, i'll get back to you...

[raetones16]

Hi all - sorry for the delay in getting this example set up. I've uploaded a zip file which contains 4 sketch documents used for test purposes. To replicate the issue:

Open the dark theme file - add as library in sketch
Open the light theme file - add as library in sketch
Open the component file - add as library in sketch

Open the product file. This file consists of symbols from the component library as well as styles from the dark theme. What we want to do is switch this product file to consume the light theme exclusively.

Go back into the component file - use camillo to apply the light theme to the document - it should complete successfully - save the file.

Go back into the product file - wait for the 'library updates available' notification (top right) and click on it, apply the library updates - these should complete fine.

The final step is to use camillo to apply the light theme to the rest of the elements in the product file but this is where the issue lies - it doesn't switch everything over, only selected styles and from this point its messed up - you have to manually change the existing items over to the light theme but then the exact same issue occurs if you're switching back to the dark theme.

[raetones16]

Hi, did you get chance to check out my tests on this?

[raetones16]

Some further investigation into this - this break occurred when v69 of Sketch was introduced (when colour variables etc were added). I've gone back to v68.2 and all works as it should again, so I'm actually convinced this is a bug that lies within Sketch and not Camilo, so will raise with the Sketch team too