GithubHelp home page GithubHelp logo

Comments (10)

jmou avatar jmou commented on May 18, 2024 2

Maybe try without the ozone flags? Those crash for me, but just this works:

./Deskreen-1.0.11.AppImage --enable-features=WebRTCPipeWireCapturer

from deskreen.

maricn avatar maricn commented on May 18, 2024 1

🔥 💣 💥 worked like a charm!! :)

from deskreen.

pavlobu avatar pavlobu commented on May 18, 2024

Hey @maricn, your problem is very specific, it may be a limitation of the current version of chromium engine of electron. Deskreen is built with electron. So maybe in never releases, when we will be updating electron, this problem will be gone.

Cheers,
Paul

from deskreen.

maricn avatar maricn commented on May 18, 2024

I'd rather guess it's related to the way wayland specifies rendering of clients to happen, although I'm a real noob with DE/WM internals.

Also, what would help from a very noobish blackbox diagnosis perspective - if deskreen would be based on a build of electron that has RTC_USE_PIPEWIRE=true flag (per https://github.com/emersion/xdg-desktop-portal-wlr/wiki/Screencast-Compatibility#electron) then we could try casting whole desktops/workspaces/screens.

For instance, I can already successfully cast my second virtual desktop through google meet conference, and that seems like a good workaround in case swaywm's (wayland's) clients wouldn't continually render when they're outside of the viewport.

Just for the sake of reference - this issue seems related just on OSX #57

I hope I didn't mumble a bunch of nonsense there 😬 it's really not my field

from deskreen.

pavlobu avatar pavlobu commented on May 18, 2024

@maricn can you check if this example works smooth on latest chromium browser in your wayland environment?
https://www.webrtc-experiment.com/Pluginfree-Screen-Sharing/#8420463382421998

if it does work, then it can be easily fixed with updating electron to latest version and making a new release to fix issues for folks using wayland

Cheers,
Paul

from deskreen.

maricn avatar maricn commented on May 18, 2024

@maricn can you check if this example works smooth on latest chromium browser in your wayland environment?
webrtc-experiment.com/Pluginfree-Screen-Sharing/#8420463382421998

Just checked it - yes it works.

Also, thanks for quick responses and good luck with the project! <3

from deskreen.

pavlobu avatar pavlobu commented on May 18, 2024

Hi,
Ok SO it is good news for you! :)

our current version of electron we are using in Deskreen is:
"electron": "^10.1.5",
that is using chromium version:
"85.0.4183.121"

The latest version of electron is:
11.2.1
that is using Chromium 87.0.4280.141

so versions differ a lot!

the last thing I want to ask you, what is the chromium version you were testing WebRTC screen sharing on your Wayland environment and you said it worked well? (the full version like above)

Cheers,
Paul

from deskreen.

maricn avatar maricn commented on May 18, 2024

Cool. Looking forward to reviving some old devices :)

I'm on Chromium Version 88.0.4324.96 (Official Build) Arch Linux (64-bit), but I'm not exactly sure from which version of Chromium the full screen share started working properly.

from deskreen.

pavlobu avatar pavlobu commented on May 18, 2024

hi, I made new release with updated chromium engine version for electron.
https://github.com/pavlobu/deskreen/releases/tag/v1.0.2
if it does fix your problem, pls share here.

Cheers,
Paul

from deskreen.

NullSense avatar NullSense commented on May 18, 2024

Hi, I am unable to get this working with the appropriate flags, as deskreen just crashes (without the flags, when sharing my screen,it's just black).
Here's a dump:

~ via 🐍 v3.9.2 on ☁️  took 6s
❯ XDG_SESSION_TYPE=wayland RTC_USE_PIPEWIRE=true ./Deskreen-1.0.11.AppImage --enable-features=WebRTCPipeWireCapturer --enable-features=UseOzonePlatform --ozone-platform=wayland
13:09:14.094 › /tmp/.mount_DeskrejrP1yx/resources/app.asar/main.prod.js : Deskreen signaling server is online at port 3131
13:09:14.454 › Checking for update
(node:8211) electron: The default of contextIsolation is deprecated and will be changing from false to true in a future release of Electron.  See https://github.com/electron/electron/issues/23506 for more information
13:09:15.112 › Update for version 1.0.11 is not available (latest version: 1.0.11, downgrade is disallowed).
13:09:15.112 › checkForUpdatesAndNotify called, downloadPromise is null
(node:8211) electron: The default of contextIsolation is deprecated and will be changing from false to true in a future release of Electron.  See https://github.com/electron/electron/issues/23506 for more information
zsh: segmentation fault (core dumped)  XDG_SESSION_TYPE=wayland RTC_USE_PIPEWIRE=true ./Deskreen-1.0.11.AppImage

Software versions:

pipewire: 1:0.3.24-1
pipewire-pulse: 1:0.3.24-1
xdg-desktop-portal-wlr: 0.2.0-1
xdg-desktop-portal:1.8.0-1
(AUR) electron12-bin: 12.0.0.beta.30-1

Running on Arch kernel 5.11.7-arch1-1. Screen sharing on chromium works.

from deskreen.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.