[Insight] PHP methods should not contain too much logic about composer-service

[pborreli]

Thinking of a Processing class to move out logic from the consumer

[liuggio]

Yes a processor class and also multiple tasks objects injected via DIC via composition.

In this way all tasks would be easily tested...

[pborreli]

agree, not sure what do you mean by task ?

[cordoval]

he means specific process command or such

[liuggio]

If the objective is clean-up a little bit and add a test for each step,
creating a similar class with a big process function is not the best.

Another solution is create a Processing class with a function for each step,
but would be difficult to have unit tests (or we test private functions that is not so good), so we'd have to add functional testing.

Another way of doing it and maybe is over engineered:
create multiple steps (or task), each step does only one thing.

New Processing

• argument:
  1. DumpFileStep
  2. ComposerInstallStep
  3. CheckVulnerabilitiesStep
  4. ServeVendorStep

The steps are classes that implements an interface with a method execute (or something like that).

Other ideas?

Other smells that I see: Filesystem and SecurityChecker are not injected.

[pborreli]

👍 feel free if you want to contribute, I'd be glad :)

[liuggio]

I'm on holiday now :) if this will be not closed when I'll come back on mid-jan I'll look into it 👍

[cordoval]

@liuggio non sapevo italiano ha preso Vacanze ❗

[pborreli]

@liuggio thanks, have a great time and happy new year ;)

[youbs]

Can I take a shot at this please?

I like this project, for now I just contributed a few lines on projects but I'd like to be more involved in some stuff.
There is a good chance that I mess this up, but eh, I have to start somewhere (plus maybe @liuggio can point me in the right direction ?) :)

[cordoval]

@youbs feel free to contribute, take a stab

[pborreli]

@youbs you are more than welcome, don't worry, we'll help you

[liuggio]

👍 @youbs let us know

[youbs]

Hi,

I started to work on this and went with @liuggio's idea with the steps.
I ran into an issue concerning the generated temp path (with the uniqid). I'd need to access it from several different steps. Anyone got an idea how to handle that?

(I can open a WIP PR if needed)

[cordoval]

please do @youbs