Dispatch additional actions? about redux-promise-middleware

[tomatau]

I think I get the reasoning for this, although I haven't gone down this more 'global' path for managing errors or loading state for the app. I tend to keep to local state.

Personally, I think this API addition would be a little bit too unique to implementation details. Many apps out there could be taking completely different approaches to tackle the same problem. Also, if I was coming fresh into a new project with requests: true, it wouldn't be super obvious that this was making the global loading spinner work correctly -- and visa versa.

So, I tend to favour more compositional approaches, such as the middleware you have described... or even, to be super explicit... having the regex match against action.type performed in a globalState reducer:

const defaultState = { isError: false, isLoading: false };
const globalStateReducer = (state=defaultState, action) => {
   switch (true) {}
    case action.type.match(pending_regex):
      return { ...state, isLoading: true }
    case action.type.match(rejected_regex):
      return { ...state, isError: true }
    default:
      return state;
   }
}

I find this approach more explicit. Although, it requires some synchronisation between the different actionTypeSuffixes and the regex checks.

But overall, happy to let the wider community decide :)

[pburtchaell]

I think you make a good point. 💯 I am going to revisit my implementation of this with your suggestion to move the regex into the reducer.