Comments (3)
I am not a Windows user so have no way of testing this. However, it seems obvious from your first patch that the file names were incorrectly set up when PCRE2 was forked from PCRE1. Looks like nobody has tried to use this in the last seven years! I have applied your changes and committed the patch.
I haven't done anything about your second message because you said "something long these lines", as though it might be incomplete or untested. If you can provide a known working patch, I will apply it.
from pcre2.
I just wanted to add that its also possible to generate and store pdb
files for static library builds. However requires that the COMPILE_PDB_NAME
is set in cmake for the target. So something along those lines would need to be added in addition to the install command from above, too:
if (MSVC AND NOT BUILD_SHARED_LIBS)
# Set the output name for debugger files, otherwise they are not generated:
set_target_properties(${PROJECT_NAME}
PROPERTIES
COMPILE_PDB_NAME_DEBUG ${PROJECT_NAME}
COMPILE_PDB_NAME_RELEASE ${PROJECT_NAME}
COMPILE_PDB_NAME_MINSIZEREL ${PROJECT_NAME}
COMPILE_PDB_NAME_RELWITHDEBINFO ${PROJECT_NAME})
endif()
Then the install command should work for the static and the shared case.
PS: I'm assuming here that the library target is called ${PROJECT_NAME}
. Otherwise please replace this with the library target(s).
from pcre2.
Thanks a lot for applying the patch, it's really appreciated! I think its fine not to support the static case, for now, so I'll close this issue? We can open a new one if the request comes up.
from pcre2.
Related Issues (20)
- MSVC warnings with 10.43 HOT 1
- Allow unlimited subpattern name length HOT 4
- SunOS-5.11-SPARC - "src/pcre2.h", line 949: warning: no explicit type given HOT 5
- pcre2 makes software crash when GDS mitigation is forced for older CPUs HOT 21
- Invalid size 0 may lead to undefined behavior / infinite loop HOT 1
- Atomic group must not increase stack depth HOT 1
- Probable thread-safety issue in pcre2 10.43+ HOT 9
- No load/store-on-condition 2 facility HOT 4
- How can I get PCRE with version under 8.45? HOT 1
- Lift compile time default maximum pattern length HOT 1
- Support W3C xpath spec. weird newline behavior regarding to DOTALL and MULTILINE HOT 6
- Grapheme cluser (`\X`) selector capturing multiple character HOT 2
- Alternative branch should match shared prefix only once HOT 3
- Might be a problem found during the metamorphosis test HOT 4
- Test suite fails when targeting i686 HOT 7
- Signing of git objects HOT 3
- Quantifier `a{,7}` not supported HOT 2
- Coverity defect: Illegal address computation HOT 5
- PCRE2 10.44 Test 8 (Internal offsets and code size) fails on 32-bit platform HOT 1
- Long-term maintenance of PCRE2 HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pcre2.