Rails 6.1 errors hash deprecation warning about csv-importer

[pcreux]

Hey @stevenou , I'm glad that this gem is saving you some time!

Thank you for reporting this. I believe that it's coming from:

csv-importer/lib/csv_importer/row.rb

Line 80 in 26d66cb

model.errors.map do |attribute, errors|

I'm wondering if this API (errors.each do |error|) is compatible with Rails 4+ or if there's something like errors.to_h.

PRs are welcomed. ;)

[stevenou]

Ok, so it would appear that csv-importer currently actually only returns the last error for each attribute, not all errors for each attribute. That's because the Hash[] here will only retain the last error if there are multiple entries with the same key (column_name/attribute)

csv-importer/lib/csv_importer/row.rb

Lines 79 to 87 in 26d66cb

	Hash[
	model.errors.map do |attribute, errors|
	if column_name = header.column_name_for_model_attribute(attribute)
	[column_name, errors]
	else
	[attribute, errors]
	end
	end
	]

Ideally, we might want to change the value in the resulting hash to be an array, rather a string, so it can hold all errors for a given attribute. However, that is probably a breaking change.

So I'll just submit a PR to remove the deprecation warning but keep the existing behavior. We can discuss the breaking change separately.

[pcreux]

You're 100% right. I'm not convinced that only keeping the last error was intentional. Let's merge your PR in for the 0.8.1 version. I believe that we could then release 0.9.0 where errors would return a hash where values would be array of errors.

[stevenou]

May I suggest making that 1.0.0 as that would be a breaking change?

[pcreux]

@stevenou Yes, that makes sense. It always feels like a big jump to release 1.0.0 but it's the right call. I'm going to look at removing the dependency to virtus since it's not maintained anymore.