Tag groups and closures about kirby-meta-tags

[bvdputte]

No problem! I think I'm the one owing an apology tbh...
Upon seeing your sample code I noticed I most probably have implemented it wrong 🙈.

I used closures on the templates instead of the options.

First I tried to implement it as following:

return [
    // other options...
    'pedroborges.meta-tags.templates' => function($page, $site) {
        return [
            'article' => function($page, $site) {
                return [
                    'og' => [
                        'type' => 'article',
                        'image' => $page->heroimage()->toFile()->url(),
                    ]
                ];
            },
        ];
    },
];

I've altered my code to your sample code, but removing the closures on the templates and putting them on the options:

return [
    // other options...
    'pedroborges.meta-tags.templates' => function($page, $site) {
        return [
            'article' => [
                'og' => [
                    'type' => 'article',
                    'image' => function($page, $site) {
                        if ($img = $page->heroimage()->toFile()) {
                            return $img->url();
                        }
                        return "";
                    }
                ]
            ],
        ];
    },
];

and now it seems to work, so I think it's intended to work like this. Right?
If it is, you can surely dismiss my PR.

[bvdputte]

FYI: Seems like replacing this with the following "fixes" it somehow:

if (isset($templates[$page->intendedTemplate()])) {
    $tagsForTemplate = $templates[$page->intendedTemplate()];
    $tagsForTemplate = is_callable($tagsForTemplate) ? $tagsForTemplate($page, site()) : $tagsForTemplate;
    $this->data = a::merge($this->data, $tagsForTemplate);
}

It's just an extra test to see if the passed array item is also a closure.

[pedroborges]

I apologize for taking so long to review this. I think there's a misunderstanding, but please let me know if you think I'm wrong 😉

Tag groups are title, meta, link, og, and twitter. Those work with closure from the beginning. After a while, I realized it would be better to accept a closure on the options. Then I added support for:

<?php

return [
    // other options...
    'pedroborges.meta-tags.templates' => function($page, $site) {
        return [
            'article' => [
                'title' => $page->title(),
                'og' => [
                    'title' => $page->title()
                ],
            ],
            'about' => [ /* tags groups */ ],
            'products' => [ /* tags groups */ ],
        ];
    },
];

Is that what you are trying to achieve?