Test fail due to cursor on EditText about shot

[pedrovgs]

Hi, @juanscigliano I'll try to answer your question but I'm also going to close this issue. We aim to use GitHub issues for bug reporting or feature request, sorry for that.

When trying to use screenshot testing every animated component has to be disabled. But just during the test execution. You need to disable the progress bar animation and the edit text cursor blinking because if you don't do that the screenshot test to become indeterminate. You'd need to wrap your components using a flavor and disable the animations, or in some point in your code detect if you are running a test or not and disable the animations.

As you might be thinking, this is a smell. Your production code should not change the behavior implemented based on if the execution context is a test runner or the production environment. But this is the only way you have to use this testing strategy. When using Espresso or screenshot testing you'll face similar issues with animations.

TLDR: You need to update your code to disable animations and the cursor just during the tests execution.

I hope this is the answer to your question. If you have any other doubt please, drop a question at stack overflow or send me an email at [email protected] and I'll try to answer 😃

[juanscigliano]

@pedrovgs Thanks for the answer, your approach make total sense.

[SUPERCILEX]

You can also recursively kill the cursors. Here's a full example for anyone wanting to copypasta stuff:

fun <T : Activity> ActivityScenario<T>.takeScreenshot() {
    lateinit var activity: Activity
    onActivity {
        activity = it
    }

    activity.hideCursors()
    Thread.sleep(500) // Wait for animations to finish

    // The automated screenshot naming is based off of stack trace analysis. We can't put this in
    // the onActivity lambda because that gets posted to the main thread.
    Screenshot.snapActivity(activity).record()
}

private fun Activity.hideCursors() {
    runOnUiThread { findViewById<ViewGroup>(android.R.id.content).hideCursors() }
}

private fun ViewGroup.hideCursors() {
    for (child in children) {
        if (child is ViewGroup) child.hideCursors()
        if (child is TextView) child.isCursorVisible = false
    }
}

[mecoFarid]

@SUPERCILEX Assumptions like wait 500 ms then you should be good to go are the reason most tests fail and we stay like a stickman thinking about what the hell caused the issue

[mecoFarid]

TLDR: You need to update your code to disable animations and the cursor just during the tests execution.

Rewriting the app :)