GithubHelp home page GithubHelp logo

Comments (4)

niwinz avatar niwinz commented on May 5, 2024

Yes, this is expected. It happens when no real change is performed (when the previous and the curent version are identical).

from penpot.

niwinz avatar niwinz commented on May 5, 2024

Or a change implies something not versioned such as page name change.

from penpot.

studiospring avatar studiospring commented on May 5, 2024

You mean versions are squashed like git commits, which changes the number? I think it would be easier for the user to understand if numbers were sequential. Here it looks like versions are missing.

from penpot.

niwinz avatar niwinz commented on May 5, 2024

I mean that when you perform some change on the page and the result of comparing the previous page data with the current page data is the same, no new history entry is created.

With page data I'm refering to the blob of data which contains the shapes. Page entity also contains metadata and some additional attributes such as name. That attributes are not versioned.

The version number is atomic and is incremented on each request of change independently if the history entry will be created or not. Maybe there are other ways to do it but that approach works for now. I'm open to revisit this part (and maybe include more attrs to the versioning, but we need more thought on it)

from penpot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.