Comments (3)
I'm forcing the job to run in foreground because I am creating a lock file and deleting it after the scheduled script is being executed. If I run the job in background I won't have a way to remove the lock file and the next cron job will never run until you manually delete the lock file.
That was the solution I found when I developed that feature, but if you have a better idea we can discuss it.
About the second issue you're absolutely right and I'm happy to merge the changes.
Thanks!
from php-cron-scheduler.
Hello @peppeocchi,
I have posted the issue by mistake from the company account.
It doesn't matter if you are running the script in foreground or background because in both cases you are removing the lock file with rm
after execution. Because every job has a unique lock file it doesn't really make sense to make them wait after each other, the lock file will be removed in both cases.
Because I am not a unix guru I have made a test on our CentOS server to confirm the statement above:
[coderoot@server test]$ touch test.lock
[coderoot@server test]$ php -v;rm test.lock > /dev/null 2>&1
PHP 5.6.30 (cli) (built: Jan 19 2017 07:57:06)
Copyright (c) 1997-2016 The PHP Group
Zend Engine v2.6.0, Copyright (c) 1998-2016 Zend Technologies
[coderoot@server test]$ ls -l
total 0
[coderoot@server test]$ touch test.lock
[coderoot@server test]$ ls -l
total 0
-rw-rw-r-- 1 coderoot coderoot 0 Feb 17 22:00 test.lock
[coderoot@server test]$ php -v;rm test.lock > /dev/null 2>&1 &
PHP 5.6.30 (cli) (built: Jan 19 2017 07:57:06)
Copyright (c) 1997-2016 The PHP Group
Zend Engine v2.6.0, Copyright (c) 1998-2016 Zend Technologies
[1] 11725
[coderoot@server test]$ ls -l
total 0
[1]+ Done rm test.lock > /dev/null 2>&1
[coderoot@server test]$ ls -l
total 0
[coderoot@server test]$
The test above confirms that it's safe to modify your $job->run
function to this:
public function run()
{
$output = [];
// First reorder the cronjobs
$this->jobsInBackgroundFirst();
foreach ($this->jobs as $job) {
$job->setup($this->config);
// Check if job is due and if it should prevent overlapping
if ($job->isDue()) {
if ($job->preventOverlap() !== false) {
// If overlapping, skip job execution
if (! $this->jobCanRun($job)) {
continue;
}
// Create lock file for this job to prevent overlap
$lockFile = implode('/', [$this->getTempDir(), md5($job->getCommand()) . '.lock']);
Filesystem::write('', $lockFile);
// Sets the file to remove after the execution
$job->removeLockAfterExec($lockFile);
}
$output[] = $job->exec();
$this->executed[] = $job;
}
}
return $output;
}
from php-cron-scheduler.
@csaba-meszaros you're right, there is no need to force the job to run in foreground.
I'll remove that line, thanks!
from php-cron-scheduler.
Related Issues (20)
- how to get the number of running tasks?
- daily() and php() not working
- How does the lock file removed HOT 2
- Intelephense suggestion issue
- Fire script from a different root HOT 4
- Minute Error HOT 1
- Task start and end time
- cannot output log file HOT 1
- no way to set timezone for each job
- This library does not work for windows HOT 3
- work() cpu 100% HOT 2
- PHP 8.1 compatibility HOT 1
- Upgrade for php version 8.1 HOT 1
- Passing date will not execute the code in background
- Error when Scheduling an Object Method using ->call()
- Remove lock file of failed only-one callable job HOT 3
- Passing parameters via register_argc_argv alternative
- How to start a worker timer function upon startup?
- Windows scheduler
- [QUESTIONS] Where are jobs stored and how to use multiple servers
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from php-cron-scheduler.