Comments (6)
Hey @joekur, thanks for the issue! Does that spec have JS enabled? Or which driver is it using?
from percy-capybara.
Yes js is enabled, using selenium headless chrome.
Edit - for clarity most specs are snapshotting just fine (same js enabled / selenium headless chrome).
from percy-capybara.
Gotcha, good to know. It's nice that it's a single test that fails consistently. This is what is failing: https://github.com/percy/percy-capybara/blob/master/lib/percy.rb#L83-L92 Which means the JS was never ran on the page: https://github.com/percy/percy-capybara/blob/master/lib/percy.rb#L65-L72
Does this test happen to have any VCR/network mocking going on?
from percy-capybara.
@Robdel12 yes there is plenty of network mocking going on. I'm not seeing the Could not load...
error in the logs like the Snapshotting failed..
one I do see. So I wonder if the error would be in the js execute? https://github.com/percy/percy-capybara/blob/master/lib/percy.rb#L84
from percy-capybara.
I did some monkeypatching to ensure I could see what was being returned by that JS fetch, and confirmed I received window.PercyAgent=function(e){...
, before seeing the snapshot failure PercyAgent is not defined
from percy-capybara.
@Robdel12 thank you for your help! I have found that this is happening because there is a race condition of redirection to a new url in this spec. I believe we injecting the percy agent, the page location changes (with window.PercyAgent
no longer defined), and then we try to take a snapshot and fail. Consider this a user error 😃
from percy-capybara.
Related Issues (20)
- Firefox autofocus HOT 3
- Styles not rendering in the screenshots HOT 4
- Canvas elements appear empty HOT 4
- Support for iFrames HOT 4
- broken snapshots dealing with DOM changes & responsiveness HOT 8
- Calling Percy.snapshot without a javascript driver silently does nothing HOT 2
- Error for duplicate snapshot name when retrying test HOT 4
- Issues with Apparition driver in 4.3.x HOT 7
- Dependabot couldn't find a package.json for this project
- 5.0.0.pre.3 breaks with `have_current_path` Capybara matcher HOT 2
- Per-snapshot widths not respected in 5.0.0.pre.4 HOT 5
- Node version requirement HOT 1
- percy-capybara 5.0.0 doesn't seem to work with cucumber
- «percy/healthcheck» does not return «x-percy-core-version»
- Global Configuration HOT 2
- What is the preferred way to define/use custom loaders? HOT 2
- Documentation around loaders HOT 15
- Webpacker 4 HOT 8
- Breaking change moving to Percy-Capybara v4 HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from percy-capybara.