References wrong about flast

[BenBaryoPX]

As I wrote a couple of hours ago, I overhauled the scoping and covered this case.
I've also taken into account issue #10, and have already merged them into main.
I really appreciate the time and effort you've put into opening the issues and PRs.

Please reopen any issue if you find they still persist.

[BenBaryoPX]

Yes this is intentional. If an identifier has a declNode property it means it is a reference.
If it has a references property - it is an identifier declared in the script.
If it has neither - it is not defined in the script (like window or process).

[royvandijk06]

Btw, this projects is great! It provides a much more usable datastructure than eslint-scope does.

[BenBaryoPX]

Definitely a scope issue. Thanks for reporting!
Following this I'm overhauling the scoping to cover this and other edge cases I've encountered.
I'll also be improving the tests so they'll cover more cases.
I've seen your PR and be getting to it right after I'm done with this issue.
Thanks again for taking the time to open an issue and a PR 🙏🙂

[royvandijk06]

Looks like the issue from my example is resolved now, thank you!

I don't know if this is intended, but only the declNode has references, but none of the references have the property references. Actually, this is not a bad design.

[royvandijk06]

Yes this is intentional. If an identifier has a declNode property it means it is a reference. If it has a references property - it is an identifier declared in the script. If it has neither - it is not defined in the script (like window or process).

Btw, might be worth mentioning this in the docs.