incorrect length in JSON? about catalyst-runtime

[jjn1056]

Looks like to a bug to me, although I'm not personally keen on the auto length setting in Catalyst it should be corrected. I'm happy to get a patch, or at the very least give me a broken test case (checkout https://github.com/perl-catalyst/catalyst-runtime/blob/master/t/utf_incoming.t

and see if you can help me figure it out -jnap

[melmothx]

If you ask me, this is not a bug. application/json is not encoded by catalyst (as per doc) so it must be encoded to bytes before setting the body. Most serializers do that, so the wrong behavior here is just because of the manual json creation.

[jjn1056]

@melmothx good catch, you'd think I'd remember that since I wrote the doc and made that call for back compat reasons. I wonder if the docs could not be more obvious and maybe I should add a config setting to 'force_json_encode_always' for people that are rolling their own... I guess I was thinking if you are doing that yourself I assume you know what you are doing...

[jjn1056]

I'm thinking the docs should at least recommend one considers setting content length in your custom view, just to be safe.

[melmothx]

John Napiorkowski [email protected] writes:

I'm thinking the docs should at least recommend one considers setting
content length in your custom view, just to be safe.

I believe that if the string is passed correctly, the content length is
set by catalyst correct as well (or at least works for me so). In the OP
report, the length was off because chars were passed and setting the
length was not going to make the situation better (because of broken
encoding).

Marco