Comments (7)
would you appreciate help on the upgrade to v4?
of course! :) But I already started to work on it just last sunday. If I find again some time, I will try to finish the remaining new functions and publish a new branch for this. Some live testers would be good just to verify the core functionalities are all fine for an actual release.
Sorry I'm so late for this, but this is just a hobby project and I just came back to it, because I thought I could use it to verify a theory in public orders 😅 .. and I also like to have everything in the project in a correct way rather then just something that works for now. So my development also includes Mocks and tests and documentation updates.
from btcde.
@ajascha @tpokorra @flynk-zz it would be great if you guys could briefly test the library in the new branch and report new issues in https://github.com/peshay/btcde/projects/6 if you find them. I like to get this thing to work and then make a new release available for it.
Further enhancements and functions from the new API can then be worked in version 4.1 https://github.com/peshay/btcde/projects/5
from btcde.
First I want to thank @peshay for this library!
The upgrade to v4 has become more urgent, because the api v2, and api v3 will be disabled on April 5th 2021.
I got this email:
Gleichzeitig möchten wir Sie darüber informieren, dass die Versionen v1, v2 und v3 unserer Trading-API ab dem 5. April nicht mehr unterstützt werden. Ab diesem Datum ist ausschließlich die im Sommer 2019 veröffentlichte Version v4 erreichbar.
The question would be where are the differences between v2 and v3, and v3 and v4?
Unfortunately, I cannot find anything for v2 and v3.
In the current changelog on https://www.bitcoin.de/de/api/tapi/doc#scrollNav-1-9, scroll down to Changelog v4.
"Sämtliche URLs bestehender Methoden sind um Handelspaar bzw. Währung ergänzt worden."
"Einige URLs bestehender Methoden haben neue Pfade erhalten. "
I am currently only using the API for fetching trades (showMyTrades, https://github.com/tpokorra/walletmonitor/blob/main/apps/transactions/importbtcde.py). That still works for me, because I am not using trading_pair which is now part of the url, and not a parameter anymore.
@peshay: would you appreciate help on the upgrade to v4?
from btcde.
I'm happy to chip in. Would be great to use this library for more shenanigans!
from btcde.
Here is the new branch: https://github.com/peshay/btcde/tree/4.0
Not yet implemented: New functions for Deposit and Withdrawal, Websocket-API.
Also not reviewed: Difference in functionality for Crypto-to-Crypto trades
from btcde.
So far it has been working well, I'll be doing a few more tests over the coming days. Tested on Python 3.8. Thanks a lot for the update!
The only thing I saw was that the following error gets thrown:
InsecureRequestWarning: Unverified HTTPS request is being made to host 'api.bitcoin.de'. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings
I never had this one before and I'm reading into the matter right now. Maybe these lines could be added to btcde directly?
from btcde.
Release for v4 API is now available: https://pypi.org/project/btcde/4.0/
from btcde.
Related Issues (20)
- Verified values as defined in API
- Reduce complexity in ParameterBuilder.verify_keys_and_values
- Documentation link is broken HOT 1
- Problem with executeTrade HOT 2
- disable debug logging HOT 3
- showMyTrades returns nothing HOT 2
- showAccountLedger: Date arguments don't work HOT 8
- Please help me to understand the **args HOT 3
- Invalid STATES check HOT 1
- Existing security issues HOT 2
- make it possible to throw API errors
- Invalid signature HOT 1
- unable to buy and sell something HOT 3
- Review difference with Crypto-to-Crypto trades in new v4 API
- Implement v4 API usage of websocket-API
- Implement v4 API functions for Withdrawal HOT 2
- Implement v4 API functions for Deposit HOT 2
- Replace nose with nose2 or pyetest
- tradingpair xrpeur HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from btcde.