Is it possible to fully restore all git state after the action? about create-pull-request

[peter-evans]

Hi @glasser

Thank you for reporting this issue.

I added the add-paths feature in v3 and the stash and restore in v5. When I added those features I didn't fully consider that it would make the action a bit inconsistent in the way that it leaves git state. The stash/restore is only used when add-paths is specified. For some state like git config/auth I've made an effort to revert all changes and leave the state as it was found. I think perhaps it makes sense to try and do that consistently for all git state.

I don't really want to add additional options to the action, unless it's unavoidable. I've made an effort to keep the interface simple and not bloated with config options. So I think reverting all state in every case is simple and intuitive.

I'll take a look at this change when I get a chance. It would require a major version bump, though, because potentially it would be a breaking change for some workflows that expect a particular git state after the action completes.

[glasser]

I would certainly be happy if v6 let me do the thing I wanted with zero extra configuration :)

[peter-evans]

I remember now why the non-config git state works this way. One of the features of this action is that you can make your own commits which get included in the PR. I think it's a bit too complicated (and probably undesirable) to try and restore those commits after the action completes, so I decided to just let the git state reflect anything that wasn't committed by add-paths.

I think I would prefer to leave it the way it is for now. I might change my mind in future.

There is a pretty straightforward workaround, as an alternative to the one you are already doing. Just run the Create Pull Request for all step in a separate job in parallel.

[glasser]

Makes sense. The downside to parallelizing is that constructing the file changes can be slow, so ideally that is shared across jobs. Though GH Actions does provide various ways to share state across jobs...

[peter-evans]

Closing for now.